Improve PhoneNumberInput

- Allow show/hide the search bar, defaults to show to keep backwards compatibilty
- Hide others/features label if there is only one type of options.

Author: Yayo-Arellano

src/Input/PhoneNumberInput/PhoneNumberInput.test.tsx

@@ -191,6 +191,39 @@ describe('<PhoneNumberInput>', () => {
     );
   });
 
+  it('should render group headers when options include both featured and non-featured', () => {
+    const { getToggleButton, getCallingCodeOptions } = renderComponent();
+    fireEvent.click(getToggleButton());
+    const [firstOption, secondOption] = getCallingCodeOptions();
+    expect(firstOption.className).not.toEqual(secondOption.className);
+  });
+
+  it('should not render group headers when all options are featured', () => {
+    const featuredOnlyCallingCodeOptions = [
+      { label: 'Indonesia', callingCode: 62, isFeatured: true },
+      { label: 'Malaysia', callingCode: 60, isFeatured: true },
+    ];
+    const { getToggleButton, getCallingCodeOptions } = renderComponent({
+      callingCodeOptions: featuredOnlyCallingCodeOptions,
+    });
+    fireEvent.click(getToggleButton());
+    const [firstOption, secondOption] = getCallingCodeOptions();
+    expect(firstOption.className).toEqual(secondOption.className);
+  });
+
+  it('should not render group headers when all options are non-featured', () => {
+    const nonFeaturedOnlyCallingCodeOptions = [
+      { label: 'Afghanistan', callingCode: 93, isFeatured: false },
+      { label: 'Albania', callingCode: 355, isFeatured: false },
+    ];
+    const { getToggleButton, getCallingCodeOptions } = renderComponent({
+      callingCodeOptions: nonFeaturedOnlyCallingCodeOptions,
+    });
+    fireEvent.click(getToggleButton());
+    const [firstOption, secondOption] = getCallingCodeOptions();
+    expect(firstOption.className).toEqual(secondOption.className);
+  });
+
   it('should focus the calling code filter input on clicking the toggle button', () => {
     const { getToggleButton, getCallingCodeFilterInput } = renderComponent();
     fireEvent.click(getToggleButton());

src/Input/PhoneNumberInput/PhoneNumberInput.tsx

@@ -34,6 +34,7 @@ export const PhoneNumberInput = ({
   isRequired,
   error,
   addon,
+  showFilterInput = false,
   ...restProps
 }: Props) => {
   const [isCallingCodeInputOpen, setIsCallingCodeInputOpen] = useState(false);
@@ -46,6 +47,20 @@ export const PhoneNumberInput = ({
     ['isFeatured', 'label'],
     ['desc', 'asc']
   );
+  const hasFeaturedOptions = callingCodeOptions.some(item => item.isFeatured);
+  const hasOtherOptions = callingCodeOptions.some(item => !item.isFeatured);
+  const shouldShowGroupHeaders = hasFeaturedOptions && hasOtherOptions;
+  const getGroupHeaderLabel = (item: CallingCodeOption, index: number) => {
+    if (!shouldShowGroupHeaders) return '';
+
+    const previousItem = callingCodeOptions[index - 1];
+    const isGroupBoundary =
+      item.isFeatured !== (previousItem || {}).isFeatured;
+
+    if (!isGroupBoundary) return '';
+
+    return item.isFeatured ? featuredOptionsLabel : otherOptionsLabel;
+  };
 
   const {
     getComboboxProps,
@@ -139,23 +154,25 @@ export const PhoneNumberInput = ({
         {...getComboboxProps()}
         data-testid="calling-code-input"
       >
-        <S.CallingCodeFilterInputGroup>
-          <S.CallingCodeFilterInput
-            {...getInputProps(
-              {
-                placeholder: callingCodeFilterInputPlaceholder,
-              },
-              { ...refErrorFix }
+        {showFilterInput && (
+          <S.CallingCodeFilterInputGroup>
+            <S.CallingCodeFilterInput
+              {...getInputProps(
+                {
+                  placeholder: callingCodeFilterInputPlaceholder,
+                },
+                { ...refErrorFix }
+              )}
+              ref={callingCodeFilterInputRef}
+              data-testid="calling-code-filter-input"
+              onFocus={onFocus}
+              onBlur={onBlur}
+            />
+            {isLoadingCallingCodeOptions && (
+              <S.CallingCodeInputLoading data-testid="calling-code-options-loading" />
             )}
-            ref={callingCodeFilterInputRef}
-            data-testid="calling-code-filter-input"
-            onFocus={onFocus}
-            onBlur={onBlur}
-          />
-          {isLoadingCallingCodeOptions && (
-            <S.CallingCodeInputLoading data-testid="calling-code-options-loading" />
-          )}
-        </S.CallingCodeFilterInputGroup>
+          </S.CallingCodeFilterInputGroup>
+        )}
         <S.CallingCodeOptionsList {...getMenuProps()}>
           {callingCodeOptions.length > 0 ? (
             callingCodeOptions.map((item, index) => (
@@ -166,11 +183,7 @@ export const PhoneNumberInput = ({
                   index,
                 })}
                 title={item.label}
-                withGroupHeader={
-                  item.isFeatured !==
-                    (callingCodeOptions[index - 1] || {}).isFeatured &&
-                  (item.isFeatured ? featuredOptionsLabel : otherOptionsLabel)
-                }
+                withGroupHeader={getGroupHeaderLabel(item, index)}
               >
                 <Flex>
                   <S.CallingCodeOptionCallingCode>
@@ -214,6 +227,7 @@ export interface Props {
   isDisableCallingCode?: boolean;
   isPlaceholderFloating?: boolean;
   isRequired?: boolean;
+  showFilterInput?: boolean;
 }
 
 export interface PhoneNumber {