Skip to content

Commit d6dbe34

Browse files
authored
Merge pull request #750 from glints-dev/fix/flaky-index-table-test-results
fix: flaky index table test results
2 parents e25c138 + f80fd61 commit d6dbe34

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

test/e2e/indexTable/indexTable.spec.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ test('IndexTable', async ({ page }) => {
55
const indexTablePage = new IndexTablePage(page);
66
await indexTablePage.goto();
77

8-
page.waitForLoadState('domcontentloaded');
8+
await page.waitForLoadState('domcontentloaded');
9+
910
await expect(indexTablePage.canvas).toHaveScreenshot('indexTable.png');
1011

1112
await indexTablePage.tableRow.hover();
@@ -18,6 +19,8 @@ test('IndexTable - bulk action', async ({ page }) => {
1819
const indexTablePage = new IndexTablePage(page);
1920
await indexTablePage.goto();
2021

22+
await page.waitForLoadState('domcontentloaded');
23+
2124
await indexTablePage.checkboxes.first().click();
2225
await expect(indexTablePage.canvas).toHaveScreenshot(
2326
'indextable-selectall-rows.png'
@@ -38,15 +41,20 @@ test('IndexTable - loading state', async ({ page }) => {
3841
const indexTablePage = new IndexTablePage(page);
3942
await indexTablePage.goto('args=loading:true');
4043

44+
await page.waitForLoadState('domcontentloaded');
45+
4146
await expect(indexTablePage.canvas).toHaveScreenshot(
4247
'indexTable-loading.png'
4348
);
4449
});
4550

4651
test('IndexTable - empty state', async ({ page }) => {
4752
const indexTablePage = new IndexTablePage(page);
53+
4854
await indexTablePage.goto('args=itemCount:0');
4955

56+
await page.waitForLoadState('domcontentloaded');
57+
5058
await expect(indexTablePage.canvas).toHaveScreenshot(
5159
'indexTable-empty-state.png'
5260
);

0 commit comments

Comments
 (0)