Merge branch 'develop' of https://github.com/globocom/GloboNetworkAPI into develop

Author: laura.panzariello

networkapi/api_interface/facade.py

@@ -577,12 +577,82 @@ def _generate_dict(interface):
         else:
             key_dict['CHANNEL_LACP_MODE'] = 'on'
 
+        # Normally used in junos plugin:
+        key_dict['LACP_SYSTEM_ID_MAC'] = __generate_lacp_system_id_mac(interface.channel.nome)
     else:
         key_dict['BOOL_INTERFACE_IN_CHANNEL'] = 0
 
+    # Normally used in junos plugin:
+    key_dict['CHASSIS_ID_LEAF_NUMBER'] = __generate_chassis_id_leaf_number(interface.equipamento.nome)
+
+    log.info("_generate_dict return value (dict values): {}".format(key_dict))
+
     return key_dict
 
 
+def __generate_chassis_id_leaf_number(equipment_name):
+
+    """
+    This function build value for CHASSIS_ID_LEAF_NUMBER, and must result 0 or 1 value.
+    For example: LF-LAB-JUN-01 returns 0 and LF-LAB-JUN-02 returns 1
+
+    :param str equipment_name:
+        ex.: LF-LAB-JUN-01 and LF-LAB-JUN-02 (last character must be 1 or 2)
+
+    :returns: 0, 1 or 'N/A' (to indicate information not available)
+    """
+
+    leaf_id_last_char = equipment_name[-1]
+    if leaf_id_last_char is '1' or '2':
+        leaf_id = int(leaf_id_last_char)
+        result = leaf_id - 1
+        log.info("__generate_chassis_id_leaf_number - equipment_name:{} result:{}".format(equipment_name, result))
+        return result
+    else:
+        message = "Could not set CHASSIS_ID_LEAF_NUMBER from name {}. This name not ends with '1' or '2'!".format(
+            equipment_name)
+        log.warning(message)
+        return 'N/A'
+
+
+def __generate_lacp_system_id_mac(channel_name):
+
+    """
+    This function build value for LACP_SYSTEM_ID_MAC Generate based on channel name.
+
+    :param str channel_name:
+        ex.: '123'
+
+    :returns:
+        ex.: like '00:00:00:00:01:23' or 'N/A' (to indicate information not available)
+    """
+
+    try:
+        # Put remaining zeros, ex.: 000000000123
+        equipment_name_zero_filled = channel_name.zfill(12)
+
+        # Run for equipment_name_zero_filled and generate the result with ":"s
+        mac_address_result = ""
+        i = 1
+        for char in equipment_name_zero_filled:
+            mac_address_result = mac_address_result + char
+            if i == 2:
+                mac_address_result = mac_address_result + ":"
+                i = 1
+                continue
+            i = i + 1
+
+        # At this point, the result has an extra character ":" (00:00:00:00:01:23:), and the code below will removed it.
+        mac_address_result = mac_address_result[:-1]
+        log.info("__generate_mac_address_based_on_name - channel_name:{} result:{}".format(
+            channel_name, mac_address_result))
+        return mac_address_result
+    except Exception as e:
+        message = "Could not set LACP_SYSTEM_ID_MAC from name {}.".format(channel_name)
+        log.warning("{} {}".format(message, e))
+        return 'N/A'
+
+
 def get_vlan_range(interface):
     log.info("get_vlan_range")
 

networkapi/plugins/Juniper/JUNOS/tests.py

@@ -3,7 +3,7 @@
 from networkapi.plugins import exceptions
 from networkapi.plugins.Juniper.JUNOS.plugin import JUNOS
 from mock import patch, MagicMock
-from jnpr.junos.exception import LockError
+from jnpr.junos.exception import RPCError, RpcError, LockError, ConfigLoadError, CommitError
 
 
 class JunosPluginTest(NetworkApiTestCase):
@@ -108,14 +108,71 @@ def test_exec_command_fail_to_lock(self, time_sleep, mock_config):
         test_exec_command_fail_to_lock
         """
 
-        time_sleep.return_value = None  # mocked to be executed instantly
-        mock_config.lock.side_effect = LockError('')
+        # Mocks
+        time_sleep.return_value = None  # to be executed instantly
+        mock_config.lock.side_effect = LockError('')  # Forced exception here
 
+        # Create plugin
         plugin = JUNOS(equipment_access=self.mock_equipment_access)
-        plugin.configuration = mock_config
+        plugin.configuration = mock_config  # add mock to plugin instance
+
+        # Test
+        with self.assertRaises(exceptions.APIException):
+            plugin.exec_command("any command")
+        plugin.configuration.lock.assert_called_with()
+
+    @patch('jnpr.junos.utils.config.Config')
+    @patch('jnpr.junos.exception.RpcError')
+    def test_exec_command_fail_to_load(self, mock_rpc_error, mock_config):
+
+        # Mocks
+        config_load_error = ConfigLoadError('')
+        config_load_error.rpc_error = mock_rpc_error
+        mock_config.load.side_effect = config_load_error  # Forced exception here
+
+        # Create plugin
+        plugin = JUNOS(equipment_access=self.mock_equipment_access)
+        plugin.configuration = mock_config  # add mock to plugin instance
+
+        # Test
+        with self.assertRaises(exceptions.APIException):
+            plugin.exec_command("any command")
+        plugin.configuration.load.assert_called_with(
+            "any command", format='set', ignore_warning=plugin.ignore_warning_list)
+
+    @patch('jnpr.junos.utils.config.Config')
+    def test_exec_command_fail_to_commit_check(self, mock_config):
+
+        # Mocks
+        error = RpcError('')
+        mock_config.commit_check.side_effect = error  # Forced exception here
+
+        # Create plugin
+        plugin = JUNOS(equipment_access=self.mock_equipment_access)
+        plugin.configuration = mock_config  # add mock to plugin instance
+
+        # Tests
+        with self.assertRaises(exceptions.APIException):
+            plugin.exec_command("any command")
+        plugin.configuration.commit_check.assert_called_with()
+
+    @patch('jnpr.junos.utils.config.Config')
+    @patch('jnpr.junos.exception.RpcError')
+    def test_exec_command_fail_to_commit_check(self, mock_rpc_error, mock_config):
+
+        # Mocks
+        error = CommitError('')
+        error.rpc_error = mock_rpc_error
+        mock_config.commit.side_effect = error  # Forced exception here
+
+        # Create plugin
+        plugin = JUNOS(equipment_access=self.mock_equipment_access)
+        plugin.configuration = mock_config  # add mock to plugin instance
 
+        # Tests
         with self.assertRaises(exceptions.APIException):
             plugin.exec_command("any command")
+        plugin.configuration.commit.assert_called_with()
 
     @patch('jnpr.junos.Device')
     def test_call_close_success(self, mock_device):