Fix url issues#411
Open
pabs3 wants to merge 2 commits into
Open
Conversation
pabs3
commented
Mar 19, 2026
pabs3
commented
- Do not add trailing slash "/" character to the base URI
- Use absolute URIs for the M3U8 files attribute
This results in incorrect URIs when the m3u8 file contains relative URIs instead of absolute URIs. The Python urllib.parse.urljoin() function used since 2023 handles joining URIs correctly for both absolute and relative URIs. Example: https://ubu-mirror.ch/hls/121812986/master.m3u8 Example: https://ubu-mirror.ch/hls/121812986/index-v1-a1.m3u8 Example: https://ubu-mirror.ch/hls/121812986/iframes-v1-a1.m3u8 Fixes: commit 8c1a047
This will mean callers don't have to manually call urljoin. Most M3U8 playlists will use absolute URIs anyway. See-also: globocom#9 Fixes: commit 638ab86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.