more reliable passing of the complex tests#524
Conversation
New versions of Kubernetes' kubeadm do not have the --skip-preflight-check option anymore. It has been replaced with --ignore-preflight-errors. While testing, it seems this flag is not needed anymore, tests can continue without it. However, the updated Kubernetes versions seem more strict about the order of objects in the .yaml files. There are two instances where the Service refers to a Pod that is defined later on. This seems to prevent the Service from getting created. Moving the Service definition to the end, and tests pass again. See-also: kubernetes/kubernetes@3a0aa06
|
Can one of the admins verify this patch? |
|
@phlogistonjohn you mentioned something similar the other day? |
|
ok to test |
|
@nixpanic I did and yes that was probably the reason for the failure. Since I was under time pressure to test I just used an older version of k8s by editing the global_vars file. |
|
On Thu, Oct 04, 2018 at 02:34:50PM +0000, John Mulligan wrote:
@nixpanic I did and yes that was probably the reason for the failure. Since I was under time pressure to test I just used an older version of k8s by editing the global_vars file.
Did you test with any older versions, say one version back from latest?
No, I did not try with an older version... If that is a feature we want
to support, it'll get a little more difficult to implement.
|
|
We've generally tried to keep things somewhat backwards-compatible, especially for being able to switch between latest and latest-1. There are some spots where we do version checking that you could use to see if it wouldn't be too bad. |
|
So what's the take on this? |
obnoxxx
left a comment
obnoxxx
left a comment
There was a problem hiding this comment.
Me again: This should have been 2 commits, imho: one for the template change and one for the ansible change (use of --skip-preflight-checks).
5 participants
New versions of Kubernetes' kubeadm do not have the
--skip-preflight-check option anymore. It has been replaced with
--ignore-preflight-errors. While testing, it seems this flag is not
needed anymore, tests can continue without it.
However, the updated Kubernetes versions seem more strict about the
order of objects in the .yaml files. There are two instances where the
Service refers to a Pod that is defined later on. This seems to prevent
the Service from getting created. Moving the Service definition to the
end, and tests pass again.
See-also: kubernetes/kubernetes@3a0aa06
This change is