Add ListCursorOptions to list Issues methods (google#3570)

Author: jberger-dynatrace

github/issues.go

@@ -118,6 +118,10 @@ type IssueListOptions struct {
 	// Since filters issues by time.
 	Since time.Time `url:"since,omitempty"`
 
+	ListCursorOptions
+
+	// Add ListOptions so offset pagination with integer type "page" query parameter is accepted
+	// since ListCursorOptions accepts "page" as string only.
 	ListOptions
 }
 
@@ -234,6 +238,10 @@ type IssueListByRepoOptions struct {
 	// Since filters issues by time.
 	Since time.Time `url:"since,omitempty"`
 
+	ListCursorOptions
+
+	// Add ListOptions so offset pagination with integer type "page" query parameter is accepted
+	// since ListCursorOptions accepts "page" as string only.
 	ListOptions
 }
 

github/issues_test.go

@@ -32,14 +32,16 @@ func TestIssuesService_List_all(t *testing.T) {
 			"since":     "2002-02-10T15:30:00Z",
 			"page":      "1",
 			"per_page":  "2",
+			"before":    "foo",
+			"after":     "bar",
 		})
 		fmt.Fprint(w, `[{"number":1}]`)
 	})
 
 	opt := &IssueListOptions{
 		"all", "closed", []string{"a", "b"}, "updated", "asc",
 		time.Date(2002, time.February, 10, 15, 30, 0, 0, time.UTC),
-		ListOptions{Page: 1, PerPage: 2},
+		ListCursorOptions{Before: "foo", After: "bar"}, ListOptions{Page: 1, PerPage: 2},
 	}
 	ctx := context.Background()
 	issues, _, err := client.Issues.List(ctx, true, opt)
@@ -155,14 +157,17 @@ func TestIssuesService_ListByRepo(t *testing.T) {
 			"sort":      "updated",
 			"direction": "asc",
 			"since":     "2002-02-10T15:30:00Z",
+			"per_page":  "1",
+			"before":    "foo",
+			"after":     "bar",
 		})
 		fmt.Fprint(w, `[{"number":1}]`)
 	})
 
 	opt := &IssueListByRepoOptions{
 		"*", "closed", "a", "c", "m", []string{"a", "b"}, "updated", "asc",
 		time.Date(2002, time.February, 10, 15, 30, 0, 0, time.UTC),
-		ListOptions{0, 0},
+		ListCursorOptions{PerPage: 1, Before: "foo", After: "bar"}, ListOptions{0, 0},
 	}
 	ctx := context.Background()
 	issues, _, err := client.Issues.ListByRepo(ctx, "o", "r", opt)