Merged
Conversation
davidchisnall
force-pushed
the
improve-locks
branch
4 times, most recently
from
b563dbb to
f8b54d9
Compare
This fixes the issue where two addresses that hash to the same address could deadlock and also fixes a performance issue due to using spinlocks with no OS-mediated sleep. Initially this makes the spinlocks.h consumers compile as C++ so that they can use C++ abstractions over futexes and similar. A lot of this code called calloc, so now has some nicer C++ wrappers for that. This also includes some fixes to work around older C++ standard libraries. Also includes some small tweaks to Cirrus, though Cirrus is going away soon so we'll need an alternative for FreeBSD CI.
davidchisnall
force-pushed
the
improve-locks
branch
from
f8b54d9 to
7b09583
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where two addresses that hash to the same address could deadlock and also fixes a performance issue due to using spinlocks with no OS-mediated sleep.