Skip to content

Small fixes #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidchisnall merged 2 commits into from
Apr 17, 2026
+3 −11
Merged

Small fixes #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e15325
Remove some largely-dead error handling.
davidchisnall Apr 17, 2026
a0e8f60
Fix almost-unreachable use-after-free.
davidchisnall Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eh_personality.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,10 +735,11 @@ OBJC_PUBLIC void objc_exception_rethrow(struct _Unwind_Exception *e)
// rethrown exception in objc_end_catch
ex->catch_count = -ex->catch_count;
_Unwind_Reason_Code err = _Unwind_Resume_or_Rethrow(e);
id object = ex->object;
free(ex);
if (_URC_END_OF_STACK == err && 0 != _objc_unexpected_exception)
{
_objc_unexpected_exception(ex->object);
_objc_unexpected_exception(object);
}
abort();
}
Expand Down
11 changes: 1 addition & 10 deletions selector_table.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,22 +484,13 @@ SEL objc_register_selector_copy(UnregisteredSelector &aSel, BOOL copyArgs)
else
{
copy->name = strdup(aSel.name);
if (copy->name == nullptr)
{
fprintf(stderr, "Failed to allocate memory for selector %s\n", aSel.name);
abort();
}
assert(copy->name);
selector_name_copies += strlen(copy->name);
}
if (copy->types != nullptr)
{
copy->types = strdup(copy->types);
if (copy->name == nullptr)
{
fprintf(stderr, "Failed to allocate memory for selector %s\n", aSel.name);
abort();
}
assert(copy->types);
selector_name_copies += strlen(copy->types);
}
}
Expand Down
Loading