Fix conflicting checks for stop point in arc.mm:emptyPool()#382
Merged
davidchisnall merged 3 commits intognustep:masterfrom Apr 20, 2026
Merged
Fix conflicting checks for stop point in arc.mm:emptyPool()#382davidchisnall merged 3 commits intognustep:masterfrom
davidchisnall merged 3 commits intognustep:masterfrom
Conversation
Member
|
Looks like the tests that cover this code are now all failing. |
…pool while looping to the stopping point
Contributor
Author
|
Oopsie! The insert point shouldn't go behind the pool if new ones are allocated. Should be all good now! |
davidchisnall
approved these changes
Apr 20, 2026
| while (1) | ||
|
|
||
| /* Find pool in which object to stop at is located. */ | ||
| while (stopPool != NULL) |
Member
There was a problem hiding this comment.
This condition is now dead. We leave the loop via either break or return, never by this condition failing.
Contributor
Author
There was a problem hiding this comment.
I'm not sure what you mean. The return is after the loop, yes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code used NULL before, so I decided to stick with that.