Skip to content

Don't return NSXMLDTD objects#547

Open
williameveretteggplant wants to merge 3 commits intognustep:masterfrom
williameveretteggplant:NSXMLDTD_crash
Open

Don't return NSXMLDTD objects#547
williameveretteggplant wants to merge 3 commits intognustep:masterfrom
williameveretteggplant:NSXMLDTD_crash

Conversation

@williameveretteggplant
Copy link
Copy Markdown
Contributor

Creating this PR for a patch. No need to merge this in.

GNUstep does not deal correctly with DTD nodes, which causes crashes. Just disable their creation until this is properly dealt with.

GNUstep does not deal correctly with DTD nodes, which causes crashes. Just disable their creation until this is properly dealt with.
Copy link
Copy Markdown
Contributor

@rfm rfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not really familiar with NSXMLNode (never having had cause to use it), this change makes no sense to me.
If, as the comment says, DTD nodes cause crashes, then please can we have some indication how/why things crash (testcases would be good) so that there is some chance of the code being fixed.
But also, if the comment is correct then why just remove two lines here and return nil? Presumably it would make more sense to comment out all the code creating DTD nodes, not just this one case.

@rfm
Copy link
Copy Markdown
Contributor

rfm commented Jan 25, 2026

I'm inclined to close this request since it appears to be an attempt to hide (instead of fix) a bug, and does not even provide a testcase (or clear statement of what conditions cause the bug) to allow the bug to be reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants