Do not change locale if "Locale" in defaults is not present#592
Merged
rfm merged 1 commit intognustep:masterfrom Apr 1, 2026
Merged
Do not change locale if "Locale" in defaults is not present#592rfm merged 1 commit intognustep:masterfrom
rfm merged 1 commit intognustep:masterfrom
Conversation
The defaultsDidChange: will trigger every time defaults change. If there is no "Locale" value in defaults it will change the _localeId of the autoupdatingLocale to nil. This change prevents it from updating the locale unless there is a value actually present in "Locale" in the defaults.
rfm
approved these changes
Apr 1, 2026
Contributor
rfm
left a comment
rfm
left a comment
There was a problem hiding this comment.
Thanks, that looks good to me (and nice and simple)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defaultsDidChange: will trigger every time defaults change. If there is no "Locale" value in defaults it will change the _localeId of the autoupdatingLocale to nil. This change prevents it from updating the locale unless there is a value actually present in "Locale" in the defaults.