CI: update scripts to mirror libs-base setup#165
Merged
fredkiefer merged 2 commits intomasterfrom Jan 6, 2023
Merged
Conversation
This is required by some tests, but currenetly disabled because some of these tests are failing.
e4d326d to
d6c1068
Compare
Member
Author
|
I also tried re-adding libs-back (with option to use different branch for manual runs), which seems to be required by some of the tests. This was previously part of the CI setup but was removed by @gcasa in b98a309 as part of #114, presumable because some tests started failing with that PR. For now I just commented out building libs-back, but if someone can fix the tests we can then re-enable it (independent of this PR). These are the tests that are currently failing with lib-back (full test logs can be downloaded from the CI run): |
Member
|
Thank you! Looks great. I do an in detail review later on but as the three environments seem to work I don't expect to find any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by Fred in gnustep/libs-base#285 (comment).
I basically took the updated libs-base scripts, removed the Windows section (GUI not supported yet), and added libs-base in dependencies.sh.
I also added the option for manual runs to use a different libs-base branch for testing.
Overall this mainly adds building GUI with libobjc2. I was wondering though, is anyone using the gnustep-1.9 runtime or could we remove this?