NSSliderCell: break tick ties towards the lower tick#478
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
DTW-Thalion
force-pushed
the
fix/nsslidercell-tick-rounding
branch
3 times, most recently
from
5d611b2 to
bc2896d
Compare
closestTickMarkValueToValue: rounded exact halves up (2.5 to 3 with integer ticks); OS X rounds them down (2.5 to 2, 7.5 to 7). Snap ties towards the lower tick to match.
DTW-Thalion
force-pushed
the
fix/nsslidercell-tick-rounding
branch
from
bc2896d to
d37ae95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[NSSliderCell closestTickMarkValueToValue:]snapped exact halves tothe upper tick (2.5 -> 3 with integer ticks over 0..10). OS X breaks
ties towards the lower tick (2.5 -> 2, 7.5 -> 7). Snap ties down to
match, leaving
GSRoundTowardsInfinity(shared with other classes)untouched. Verified on a macOS runner.
Adds a test for the tie rounding.