NSParagraphStyle: setTabStops: keeps the given order#479
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
DTW-Thalion
force-pushed
the
fix/nsparagraphstyle-tabstops-order
branch
4 times, most recently
from
5671661 to
14c9b37
Compare
setTabStops: sorted the stops by location; OS X keeps them in the order given. Store them as given. addTabStop: still inserts a single stop in sorted position.
DTW-Thalion
force-pushed
the
fix/nsparagraphstyle-tabstops-order
branch
from
14c9b37 to
ca1b3d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[NSMutableParagraphStyle setTabStops:]sorted the given stops bylocation. OS X keeps them in the order supplied (it is the caller's
responsibility to order them). Store the stops as given.
-addTabStop:still inserts a single stop in sorted position, which also matches OS X.
Verified on a macOS runner: setTabStops with (300, 100, 200) reports that
same order.
Adds a test for the preserved order.