NSMatrix: selectCellAtRow:column: selects a single cell in list mode#480
Open
DTW-Thalion wants to merge 1 commit into
Open
NSMatrix: selectCellAtRow:column: selects a single cell in list mode#480DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
DTW-Thalion
force-pushed
the
fix/nsmatrix-list-single-select
branch
3 times, most recently
from
78e1e81 to
6a36805
Compare
In list mode selectCellAtRow:column: added to the selection instead of replacing it, so it could not be used to move a single selection. OS X deselects the other cells. Deselect the existing selection in list mode before selecting. Mouse dragging, which uses other methods, still extends the selection.
DTW-Thalion
force-pushed
the
fix/nsmatrix-list-single-select
branch
from
6a36805 to
1f464d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In list mode,
-[NSMatrix selectCellAtRow:column:]added the cell to theselection instead of replacing it, so calling it twice left two cells
selected. OS X selects a single cell (deselecting the others) in list
mode as well as radio mode. Deselect the existing selection in list mode
before selecting the cell. Mouse dragging, which extends the selection,
uses other methods and is unaffected. Verified on a macOS runner: two
selectCellAtRow:column:calls leave one cell selected.Adds a test for the single selection.