NSTextFieldCell: default text colour is the control text colour#482
Open
DTW-Thalion wants to merge 1 commit into
Open
NSTextFieldCell: default text colour is the control text colour#482DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
DTW-Thalion
force-pushed
the
fix/nstextfieldcell-default-textcolor
branch
3 times, most recently
from
bc96876 to
69206b9
Compare
The default text colour was the generic textColor; a text field is a control, and OS X uses controlTextColor. Use controlTextColor to match.
DTW-Thalion
force-pushed
the
fix/nstextfieldcell-default-textcolor
branch
from
69206b9 to
92f5879
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[NSTextFieldCell initTextCell:]set the default text colour to thegeneric
[NSColor textColor]. A text field is a control, and OS X usescontrolTextColoras the default text colour of an NSTextFieldCell. UsecontrolTextColorto match. Verified on a macOS runner: a freshNSTextFieldCell reports
controlTextColor, nottextColor.Adds a test for the default text colour.