NSComboBoxCell: completedString: returns nil on no match#484
Open
DTW-Thalion wants to merge 1 commit into
Open
NSComboBoxCell: completedString: returns nil on no match#484DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
DTW-Thalion
force-pushed
the
fix/nscomboboxcell-completedstring-nil
branch
3 times, most recently
from
c3bc89d to
2360267
Compare
completedString: echoed the substring back when no item completed it; OS X returns nil. Return nil so callers can tell that there was no completion.
DTW-Thalion
force-pushed
the
fix/nscomboboxcell-completedstring-nil
branch
from
2360267 to
60cdb50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[NSComboBoxCell completedString:]returned the substring itself when noitem in the list completed it. OS X returns nil in that case, which is
how a caller distinguishes "no completion" from "the text is already a
complete item". Return nil when nothing matches. The two internal
callers already handle a nil result. Verified on a macOS runner:
completedString: for a non-matching prefix returns nil.
Adds a test for the no-match case.