NSTableColumn: keep the resizable flag and resizing mask consistent#489
Open
DTW-Thalion wants to merge 1 commit into
Open
NSTableColumn: keep the resizable flag and resizing mask consistent#489DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
DTW-Thalion
force-pushed
the
fix/nstablecolumn-resizable-mask
branch
3 times, most recently
from
da93163 to
e71b730
Compare
isResizable and the resizing mask were independent: setResizingMask: did not affect isResizable, and setResizable: did not affect the mask. OS X derives one from the other. Make setResizable: set the mask (to the auto/user combination or to no resizing) and setResizingMask: update the resizable flag, so the two stay consistent.
DTW-Thalion
force-pushed
the
fix/nstablecolumn-resizable-mask
branch
from
e71b730 to
ef1a6ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[NSTableColumn isResizable]and the resizing mask were independent:setResizingMask:did not affectisResizable, andsetResizable:didnot touch the mask (the existing code had a TODO noting this). OS X keeps
the two consistent --
isResizablereflects whether the mask allows anyresizing, and
setResizable:sets the mask.Make
setResizable:set the mask to the auto/user resizing combination(YES) or to no resizing (NO), and
setResizingMask:update the resizableflag from whether the mask allows any resizing.
isResizablestays thevalue serialised by the coder, which both setters now keep in step with
the mask. Verified on a macOS runner across the four combinations.
Adds a test for the resizable/mask relationship.