NSMatrix: no cell class when a prototype is used#492
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
DTW-Thalion
force-pushed
the
fix/nsmatrix-cellclass-prototype
branch
3 times, most recently
from
f9153c8 to
46d3fd6
Compare
-cellClass returned the prototype cell's class when the matrix was set up with a prototype. OS X returns nil in that case (the cell class and the prototype are alternatives). Return Nil while a prototype is set. The stored class is left untouched, so the coder and cell creation are unaffected.
DTW-Thalion
force-pushed
the
fix/nsmatrix-cellclass-prototype
branch
from
46d3fd6 to
4c61e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[NSMatrix cellClass]returned the prototype cell's class when thematrix was built with a prototype. A matrix's cell class and its
prototype are alternatives, and OS X returns nil from
cellClasswhile aprototype is set. Return
Nilin that case. The stored class is leftuntouched (it is still what
setPrototype:records for the archiver andis unused for cell creation while a prototype is set), so the coder and
cell creation are unaffected. Verified on a macOS runner: a
prototype-built matrix reports no cell class.
Adds a test for the cell class / prototype relationship.