tests: add NSFontDescriptor tests#502
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
Cover the attribute round-trip, the point size, postscript name and matrix extractors, and the descriptor derivation methods. The symbolic traits and the postscript name of an attribute-less descriptor depend on font resolution and are not covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage for NSFontDescriptor: the attribute round-trip and objectForKey:, the pointSize, postscriptName (including the space stripping) and matrix extractors, fontDescriptorWithSize:, fontDescriptorByAddingAttributes: and fontDescriptorWithFamily:.
Checked against Cocoa on macOS. The symbolic traits and the postscript name of an attribute-less descriptor depend on resolving the descriptor against the font system, which this class does not do, so they are left out. Everything covered here matches, so this is tests only.