NSTextBlock: give NSTextBlockDimension its AppKit values#504
Open
DTW-Thalion wants to merge 2 commits into
Open
NSTextBlock: give NSTextBlockDimension its AppKit values#504DTW-Thalion wants to merge 2 commits into
DTW-Thalion wants to merge 2 commits into
Conversation
Cover NSTextBlock, NSTextTable and NSTextTableBlock: the defaults, the dimension, width, colour and vertical alignment accessors, the table defaults and flags, and the table block position accessors.
The height dimensions were numbered one short: AppKit leaves the value 3 unused, so NSTextBlockHeight is 4, not 3, and the minimum and maximum heights follow. The backing arrays are sized from NSTextBlockMaximumHeight so they grow to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSTextBlockDimension numbered the height dimensions one short. AppKit leaves the value 3 unused: NSTextBlockHeight is 4, NSTextBlockMinimumHeight 5 and NSTextBlockMaximumHeight 6. Verified against Cocoa on macOS. The backing _value/_valueType arrays are sized from NSTextBlockMaximumHeight, so they grow to seven and the existing named-constant indexing keeps working.
Stacked on #503 (adds an assertion to its NSTextTable test); merge that first. Will rebase to an incremental diff once it lands.