NSTextBlock: give NSTextBlockLayer its AppKit values#505
Open
DTW-Thalion wants to merge 3 commits into
Open
Conversation
Cover NSTextBlock, NSTextTable and NSTextTableBlock: the defaults, the dimension, width, colour and vertical alignment accessors, the table defaults and flags, and the table block position accessors.
The height dimensions were numbered one short: AppKit leaves the value 3 unused, so NSTextBlockHeight is 4, not 3, and the minimum and maximum heights follow. The backing arrays are sized from NSTextBlockMaximumHeight so they grow to match.
NSTextBlockPadding is -1 in AppKit, with the border at 0 and the margin at 1, not 0/1/2. The width arrays are now indexed by the offset from NSTextBlockPadding, so the padding layer maps to the first slot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSTextBlockLayer numbered the layers 0/1/2. In AppKit NSTextBlockPadding is -1, NSTextBlockBorder is 0 and NSTextBlockMargin is 1. Verified against Cocoa on macOS.
The width arrays are indexed by the layer, so they are now sized and indexed by the offset from NSTextBlockPadding (padding maps to the first slot). No public method signature changes.
Stacked on #504 and #503; merge those first. Will rebase to an incremental diff once they land.