Skip to content

PostStart hook runs before servers are actually listening #86

@ankurs

Description

@ankurs

PostStart hooks run after server goroutines are launched but before runGRPC/runHTTP have actually bound their listeners (both call net.Listen + Serve inside the goroutine).

To fix: separate listener creation from serving — create net.Listener first, then pass to Serve() in the goroutine. Add a readiness signal (channel or WaitGroup) so PostStart runs only after both servers report they're listening.

Raised from #85 review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions