✨Can you read https://mfbmina.dev/en/posts/waitgroups/ and apply the new function wg.Go in sponge?

Author: Eric-Guo

cmd/sponge/commands/assistant/woker.go

@@ -62,14 +62,12 @@ func NewWorkerPool(ctx context.Context, workerSize int, jobQueueSize int) (*Work
 // Start starts the worker pool
 func (wp *WorkerPool) Start() {
 	for i := 0; i < wp.workerCount; i++ {
-		wp.wg.Add(1)
-		go wp.worker()
+		wp.wg.Go(func() { wp.worker() })
 	}
 }
 
 // worker is the goroutine that actually executes tasks
 func (wp *WorkerPool) worker() {
-	defer wp.wg.Done()
 	for {
 		select {
 		case job, ok := <-wp.jobQueue:

cmd/sponge/commands/perftest/common/progress_bar.go

@@ -147,8 +147,7 @@ func NewTimeBar(totalDuration time.Duration) *TimeBar {
 // Start begins automatic updates in a background goroutine.
 func (b *TimeBar) Start() {
 	b.startTime = time.Now()
-	b.wg.Add(1)
-	go b.run()
+	b.wg.Go(func() { b.run() })
 }
 
 // stopped is an internal helper to handle shutting down the progress bar.
@@ -178,8 +177,6 @@ func (b *TimeBar) Stop() {
 
 // run periodically refreshes the bar in the background.
 func (b *TimeBar) run() {
-	defer b.wg.Done()
-
 	ticker := time.NewTicker(500 * time.Millisecond)
 	defer ticker.Stop()
 

cmd/sponge/commands/perftest/http/run.go

@@ -125,14 +125,12 @@ func (p *PerfTestHTTP) RunWithFixedRequestsNum(globalCtx context.Context) (*Stat
 	}
 
 	for i := 0; i < p.Worker; i++ {
-		wg.Add(1)
-		go func() {
-			defer wg.Done()
+		wg.Go(func() {
 			for range jobs {
 				requestOnce(p.Client, p.Params, resultCh)
 				bar.Increment()
 			}
-		}()
+		})
 	}
 
 	start = time.Now()
@@ -214,19 +212,17 @@ func (p *PerfTestHTTP) RunWithFixedDuration(globalCtx context.Context) (*Statist
 
 	// Start workers
 	for i := 0; i < p.Worker; i++ {
-		wg.Add(1)
-		go func() {
-			defer wg.Done()
+		wg.Go(func() {
 			// Keep sending requests until the context is canceled
 			for {
 				select {
 				case <-ctx.Done():
-					return // Exit goroutine when context is canceled
+					return
 				default:
 					requestOnce(p.Client, p.Params, resultCh)
 				}
 			}
-		}()
+		})
 	}
 
 	start = time.Now()

cmd/sponge/commands/perftest/websocket/client.go

@@ -61,8 +61,7 @@ func (c *Client) Dial(ctx context.Context) error {
 }
 
 // Run starts the client worker.
-func (c *Client) Run(ctx context.Context, wg *sync.WaitGroup) {
-	defer wg.Done()
+func (c *Client) Run(ctx context.Context) {
 
 	err := c.Dial(ctx)
 	if err != nil {

cmd/sponge/commands/perftest/websocket/websocket.go

@@ -149,9 +149,8 @@ func (p *perfTestParams) run() error {
 			break
 		}
 
-		wg.Add(1)
 		client := NewClient(i+1, p.targetURL, stats, p.sendInterval, p.payloadData, p.isJSON)
-		go client.Run(mainCtx, &wg)
+		wg.Go(func() { client.Run(mainCtx) })
 
 		if rampUpDelay > 0 {
 			time.Sleep(rampUpDelay)

cmd/sponge/commands/plugins.go

@@ -148,10 +148,9 @@ func installPlugins(lackNames []string) {
 			continue
 		}
 
-		wg.Add(1)
-		go func(name string) {
-			defer wg.Done()
-			ctx, _ := context.WithTimeout(context.Background(), time.Minute*3) //nolint
+		wg.Go(func() {
+			ctx, cancel := context.WithTimeout(context.Background(), time.Minute*3)
+			defer cancel()
 			pkgAddr, ok := installPluginCommands[name]
 			if !ok {
 				return
@@ -166,7 +165,7 @@ func installPlugins(lackNames []string) {
 			} else {
 				fmt.Printf("%s %s\n", installedSymbol, name)
 			}
-		}(name)
+		})
 	}
 
 	wg.Wait()

go.mod

@@ -1,6 +1,6 @@
 module github.com/go-dev-frame/sponge
 
-go 1.23.0
+go 1.25.0
 
 require (
 	github.com/DATA-DOG/go-sqlmock v1.5.0