osfs: Create dir for BoundOS Tempfiles

Previously if the dir didn't already exist an error would be returned,
which meant that some go-git features would break when changing ChrootOS
with BoundOS.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>

Author: pjbgf

osfs/os_bound.go

@@ -153,6 +153,14 @@ func (fs *BoundOS) TempFile(dir, prefix string) (billy.File, error) {
 		if err != nil {
 			return nil, err
 		}
+
+		_, err = os.Stat(dir)
+		if err != nil && os.IsNotExist(err) {
+			err = os.MkdirAll(dir, defaultDirectoryMode)
+			if err != nil {
+				return nil, err
+			}
+		}
 	}
 
 	return tempFile(dir, prefix)

osfs/os_bound_test.go

@@ -279,18 +279,22 @@ func TestTempFile(t *testing.T) {
 	require.NoError(t, f.Close())
 
 	f, err = fs.TempFile("/above/cwd", "prefix")
-	require.ErrorContains(t, err, fmt.Sprint(dir, filepath.FromSlash("/above/cwd/prefix")))
-	assert.Nil(f)
+	require.NoError(t, err)
+	assert.NotNil(f)
+	assert.Contains(f.Name(), filepath.Join(dir, "/above/cwd", "prefix"))
+	require.NoError(t, f.Close())
 
-	tempDir := os.TempDir()
+	dir = os.TempDir()
 	// For windows, volume name must be removed.
-	if v := filepath.VolumeName(tempDir); v != "" {
-		tempDir = strings.TrimPrefix(tempDir, v)
+	if v := filepath.VolumeName(dir); v != "" {
+		dir = strings.TrimPrefix(dir, v)
 	}
 
-	f, err = fs.TempFile(tempDir, "prefix")
-	require.ErrorContains(t, err, filepath.Join(dir, tempDir, "prefix"))
-	assert.Nil(f)
+	f, err = fs.TempFile(dir, "prefix")
+	require.NoError(t, err)
+	assert.NotNil(f)
+	assert.Contains(f.Name(), filepath.Join(dir, "prefix"))
+	require.NoError(t, f.Close())
 }
 
 func TestChroot(t *testing.T) {