Add support to get last run migration and also automatic rollback#117
Open
oxyno-zeta wants to merge 5 commits into
Open
Add support to get last run migration and also automatic rollback#117oxyno-zeta wants to merge 5 commits into
oxyno-zeta wants to merge 5 commits into
Conversation
Author
|
Sorry for the duplicated PR (see #77 ). When you "merged" it, I just saw that a bot have removed all my commits :( . Those are separated now. |
|
@andreynering I'd appreciate it if this could be merged soon, I'm waiting on this functionality for a project. Thank you. |
dgunay
suggested changes
Mar 29, 2022
| } | ||
|
|
||
| func (g *Gormigrate) GetLastRunMigration() (*Migration, error) { | ||
| return g.getLastRunMigration() |
There was a problem hiding this comment.
This causes a nil pointer dereference because it eventually calls migrationRan, which needs there to be an active transaction ongoing, but begin() is never called so g.tx is nil.
Author
There was a problem hiding this comment.
Good catch ! Should be ok now no ?
dgunay
approved these changes
Apr 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That will resolve issue #76 .
Other commit will fix the example usage and also some test stability.