ci: migrate from Travis to GitHub Actions (#35)

unknwon · Sourcegraph Bot · web-flow · commit 735334c06273 · 2020-03-28T15:52:43.000+08:00
* ci: migrate from Travis to GitHub Actions

* Fix lint errors

* README

Co-authored-by: Sourcegraph Bot &lt;campaigns@sourcegraph.com&gt;
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -0,0 +1,45 @@
+name: Go
+on:
+  push:
+    branches: [master]
+  pull_request:
+env:
+  GOPROXY: "https://proxy.golang.org"
+
+jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Run golangci-lint
+        uses: actions-contrib/golangci-lint@v1
+
+  test:
+    name: Test
+    strategy:
+      matrix:
+        go-version: [1.13.x, 1.14.x]
+        platform: [ubuntu-latest, macos-latest, windows-latest]
+    runs-on: ${{ matrix.platform }}
+    steps:
+      - name: Install Go
+        uses: actions/setup-go@v1
+        with:
+          go-version: ${{ matrix.go-version }}
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Run unit tests
+        run: go test -v -race -coverprofile=coverage -covermode=atomic ./...
+      - name: Upload coverage report to Codecov
+        uses: codecov/codecov-action@v1.0.6
+        with:
+          file: ./coverage
+          flags: unittests
+      - name: Cache downloaded modules
+        uses: actions/cache@v1
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-
diff --git a/.travis.yml b/.travis.yml
diff --git a/README.md b/README.md
@@ -1,4 +1,9 @@
-# binding [![Build Status](https://travis-ci.org/go-macaron/binding.svg?branch=master)](https://travis-ci.org/go-macaron/binding) [![Sourcegraph](https://sourcegraph.com/github.com/go-macaron/binding/-/badge.svg)](https://sourcegraph.com/github.com/go-macaron/binding?badge)
+# binding
+
+[![GitHub Workflow Status](https://img.shields.io/github/workflow/status/go-macaron/binding/Go?logo=github&style=for-the-badge)](https://github.com/go-macaron/binding/actions?query=workflow%3AGo)
+[![codecov](https://img.shields.io/codecov/c/github/go-macaron/binding/master?logo=codecov&style=for-the-badge)](https://codecov.io/gh/go-macaron/binding)
+[![GoDoc](https://img.shields.io/badge/GoDoc-Reference-blue?style=for-the-badge&logo=go)](https://pkg.go.dev/github.com/go-macaron/binding?tab=doc)
+[![Sourcegraph](https://img.shields.io/badge/view%20on-Sourcegraph-brightgreen.svg?style=for-the-badge&logo=sourcegraph)](https://sourcegraph.com/github.com/go-macaron/binding)
 
 Middleware binding provides request data binding and validation for [Macaron](https://github.com/go-macaron/macaron).
 
diff --git a/binding.go b/binding.go
@@ -38,11 +38,11 @@ func bind(ctx *macaron.Context, obj interface{}, ifacePtr ...interface{}) {
 	if ctx.Req.Method == "POST" || ctx.Req.Method == "PUT" || ctx.Req.Method == "PATCH" || ctx.Req.Method == "DELETE" {
 		switch {
 		case strings.Contains(contentType, "form-urlencoded"):
-			ctx.Invoke(Form(obj, ifacePtr...))
+			_, _ = ctx.Invoke(Form(obj, ifacePtr...))
 		case strings.Contains(contentType, "multipart/form-data"):
-			ctx.Invoke(MultipartForm(obj, ifacePtr...))
+			_, _ = ctx.Invoke(MultipartForm(obj, ifacePtr...))
 		case strings.Contains(contentType, "json"):
-			ctx.Invoke(Json(obj, ifacePtr...))
+			_, _ = ctx.Invoke(Json(obj, ifacePtr...))
 		default:
 			var errors Errors
 			if contentType == "" {
@@ -54,7 +54,7 @@ func bind(ctx *macaron.Context, obj interface{}, ifacePtr ...interface{}) {
 			ctx.Map(obj) // Map a fake struct so handler won't panic.
 		}
 	} else {
-		ctx.Invoke(Form(obj, ifacePtr...))
+		_, _ = ctx.Invoke(Form(obj, ifacePtr...))
 	}
 }
 
@@ -83,7 +83,7 @@ func errorHandler(errs Errors, rw http.ResponseWriter) {
 			rw.WriteHeader(STATUS_UNPROCESSABLE_ENTITY)
 		}
 		errOutput, _ := json.Marshal(errs)
-		rw.Write(errOutput)
+		_, _ = rw.Write(errOutput)
 		return
 	}
 }
@@ -103,11 +103,11 @@ func Bind(obj interface{}, ifacePtr ...interface{}) macaron.Handler {
 	return func(ctx *macaron.Context) {
 		bind(ctx, obj, ifacePtr...)
 		if handler, ok := obj.(ErrorHandler); ok {
-			ctx.Invoke(handler.Error)
+			_, _ = ctx.Invoke(handler.Error)
 		} else if CustomErrorHandler != nil {
-			ctx.Invoke(CustomErrorHandler)
+			_, _ = ctx.Invoke(CustomErrorHandler)
 		} else {
-			ctx.Invoke(errorHandler)
+			_, _ = ctx.Invoke(errorHandler)
 		}
 	}
 }
@@ -176,7 +176,7 @@ func MultipartForm(formStruct interface{}, ifacePtr ...interface{}) macaron.Hand
 				}
 
 				if ctx.Req.Form == nil {
-					ctx.Req.ParseForm()
+					_ = ctx.Req.ParseForm()
 				}
 				for k, v := range form.Value {
 					ctx.Req.Form[k] = append(ctx.Req.Form[k], v...)
@@ -284,8 +284,8 @@ func Validate(obj interface{}) macaron.Handler {
 }
 
 var (
-	AlphaDashPattern    = regexp.MustCompile("[^\\d\\w-_]")
-	AlphaDashDotPattern = regexp.MustCompile("[^\\d\\w-_\\.]")
+	AlphaDashPattern    = regexp.MustCompile(`[^\d\w-_]`)
+	AlphaDashDotPattern = regexp.MustCompile(`[^\d\w-_\.]`)
 	EmailPattern        = regexp.MustCompile("[\\w!#$%&'*+/=?^_`{|}~-]+(?:\\.[\\w!#$%&'*+/=?^_`{|}~-]+)*@(?:[\\w](?:[\\w-]*[\\w])?\\.)+[a-zA-Z0-9](?:[\\w-]*[\\w])?")
 )
 
@@ -744,7 +744,7 @@ func ensureNotPointer(obj interface{}) {
 // with errors from deserialization, then maps both the
 // resulting struct and the errors to the context.
 func validateAndMap(obj reflect.Value, ctx *macaron.Context, errors Errors, ifacePtr ...interface{}) {
-	ctx.Invoke(Validate(obj.Interface()))
+	_, _ = ctx.Invoke(Validate(obj.Interface()))
 	errors = append(errors, getErrors(ctx)...)
 	ctx.Map(errors)
 	ctx.Map(obj.Elem().Interface())
diff --git a/common_test.go b/common_test.go
@@ -49,7 +49,7 @@ type (
 		Coauthor    *Person `json:"coauthor"`
 		HeaderImage *multipart.FileHeader
 		Pictures    []*multipart.FileHeader `form:"picture"`
-		unexported  string                  `form:"unexported"`
+		unexported  string                  `form:"unexported"` //nolint
 	}
 
 	EmbedPerson struct {
diff --git a/errorhandler_test.go b/errorhandler_test.go
@@ -149,7 +149,7 @@ func performErrorTest(t *testing.T, testCase errorTestCase) {
 
 type (
 	errorTestCase struct {
-		description string
+		description string //nolint
 		errors      Errors
 		expected    errorTestResult
 	}
diff --git a/file_test.go b/file_test.go
@@ -130,15 +130,15 @@ func buildRequestWithFile(testCase fileTestCase) *http.Request {
 		if err != nil {
 			panic("Could not create FormFile (single file): " + err.Error())
 		}
-		formFileSingle.Write([]byte(testCase.singleFile.data))
+		_, _ = formFileSingle.Write([]byte(testCase.singleFile.data))
 	}
 
 	for _, file := range testCase.multipleFiles {
 		formFileMultiple, err := w.CreateFormFile("picture", file.fileName)
 		if err != nil {
 			panic("Could not create FormFile (multiple files): " + err.Error())
 		}
-		formFileMultiple.Write([]byte(file.data))
+		_, _ = formFileMultiple.Write([]byte(file.data))
 	}
 
 	err := w.Close()
@@ -179,7 +179,6 @@ func unpackFileHeaderData(fh *multipart.FileHeader) string {
 type (
 	fileTestCase struct {
 		description   string
-		input         BlogPost
 		singleFile    *fileInfo
 		multipleFiles []*fileInfo
 	}
diff --git a/go.sum b/go.sum
@@ -37,3 +37,5 @@ gopkg.in/ini.v1 v1.46.0 h1:VeDZbLYGaupuvIrsYCEOe/L/2Pcs5n7hdO1ZTjporag=
 gopkg.in/ini.v1 v1.46.0/go.mod h1:pNLf8WUiyNEtQjuu5G5vTm06TEv9tsIgeAvK8hOrP4k=
 gopkg.in/macaron.v1 v1.3.4 h1:HvIscOwxhFhx3swWM/979wh2QMYyuXrNmrF9l+j3HZs=
 gopkg.in/macaron.v1 v1.3.4/go.mod h1:/RoHTdC8ALpyJ3+QR36mKjwnT1F1dyYtsGM9Ate6ZFI=
+gopkg.in/macaron.v1 v1.3.5 h1:FUA16VFBojxzfU75KqWrV/6BPv9O2R1GnybSGRie9QQ=
+gopkg.in/macaron.v1 v1.3.5/go.mod h1:uMZCFccv9yr5TipIalVOyAyZQuOH3OkmXvgcWwhJuP4=
diff --git a/multipart_test.go b/multipart_test.go
@@ -131,15 +131,15 @@ func makeMultipartPayload(testCase multipartFormTestCase) (*bytes.Buffer, *multi
 		body.Write([]byte(`--` + writer.Boundary() + `\nContent-Disposition: form-data; name="foo"\n\n--` + writer.Boundary() + `--`))
 		return body, writer
 	} else {
-		writer.WriteField("title", testCase.inputAndExpected.Title)
-		writer.WriteField("content", testCase.inputAndExpected.Content)
-		writer.WriteField("id", strconv.Itoa(testCase.inputAndExpected.Id))
-		writer.WriteField("ignored", testCase.inputAndExpected.Ignored)
+		_ = writer.WriteField("title", testCase.inputAndExpected.Title)
+		_ = writer.WriteField("content", testCase.inputAndExpected.Content)
+		_ = writer.WriteField("id", strconv.Itoa(testCase.inputAndExpected.Id))
+		_ = writer.WriteField("ignored", testCase.inputAndExpected.Ignored)
 		for _, value := range testCase.inputAndExpected.Ratings {
-			writer.WriteField("rating", strconv.Itoa(value))
+			_ = writer.WriteField("rating", strconv.Itoa(value))
 		}
-		writer.WriteField("name", testCase.inputAndExpected.Author.Name)
-		writer.WriteField("email", testCase.inputAndExpected.Author.Email)
+		_ = writer.WriteField("name", testCase.inputAndExpected.Author.Name)
+		_ = writer.WriteField("email", testCase.inputAndExpected.Author.Email)
 		return body, writer
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,11 @@ func bind(ctx *macaron.Context, obj interface{}, ifacePtr ...interface{}) {`
`38`	`38`	`if ctx.Req.Method == "POST" \|\| ctx.Req.Method == "PUT" \|\| ctx.Req.Method == "PATCH" \|\| ctx.Req.Method == "DELETE" {`
`39`	`39`	`switch {`
`40`	`40`	`case strings.Contains(contentType, "form-urlencoded"):`
`41`		`- ctx.Invoke(Form(obj, ifacePtr...))`
	`41`	`+ _, _ = ctx.Invoke(Form(obj, ifacePtr...))`
`42`	`42`	`case strings.Contains(contentType, "multipart/form-data"):`
`43`		`- ctx.Invoke(MultipartForm(obj, ifacePtr...))`
	`43`	`+ _, _ = ctx.Invoke(MultipartForm(obj, ifacePtr...))`
`44`	`44`	`case strings.Contains(contentType, "json"):`
`45`		`- ctx.Invoke(Json(obj, ifacePtr...))`
	`45`	`+ _, _ = ctx.Invoke(Json(obj, ifacePtr...))`
`46`	`46`	`default:`
`47`	`47`	`var errors Errors`
`48`	`48`	`if contentType == "" {`
`@@ -54,7 +54,7 @@ func bind(ctx *macaron.Context, obj interface{}, ifacePtr ...interface{}) {`
`54`	`54`	`ctx.Map(obj) // Map a fake struct so handler won't panic.`
`55`	`55`	`}`
`56`	`56`	`} else {`
`57`		`- ctx.Invoke(Form(obj, ifacePtr...))`
	`57`	`+ _, _ = ctx.Invoke(Form(obj, ifacePtr...))`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
`@@ -83,7 +83,7 @@ func errorHandler(errs Errors, rw http.ResponseWriter) {`
`83`	`83`	`rw.WriteHeader(STATUS_UNPROCESSABLE_ENTITY)`
`84`	`84`	`}`
`85`	`85`	`errOutput, _ := json.Marshal(errs)`
`86`		`- rw.Write(errOutput)`
	`86`	`+ _, _ = rw.Write(errOutput)`
`87`	`87`	`return`
`88`	`88`	`}`
`89`	`89`	`}`
`@@ -103,11 +103,11 @@ func Bind(obj interface{}, ifacePtr ...interface{}) macaron.Handler {`
`103`	`103`	`return func(ctx *macaron.Context) {`
`104`	`104`	`bind(ctx, obj, ifacePtr...)`
`105`	`105`	`if handler, ok := obj.(ErrorHandler); ok {`
`106`		`- ctx.Invoke(handler.Error)`
	`106`	`+ _, _ = ctx.Invoke(handler.Error)`
`107`	`107`	`} else if CustomErrorHandler != nil {`
`108`		`- ctx.Invoke(CustomErrorHandler)`
	`108`	`+ _, _ = ctx.Invoke(CustomErrorHandler)`
`109`	`109`	`} else {`
`110`		`- ctx.Invoke(errorHandler)`
	`110`	`+ _, _ = ctx.Invoke(errorHandler)`
`111`	`111`	`}`
`112`	`112`	`}`
`113`	`113`	`}`
`@@ -176,7 +176,7 @@ func MultipartForm(formStruct interface{}, ifacePtr ...interface{}) macaron.Hand`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`if ctx.Req.Form == nil {`
`179`		`- ctx.Req.ParseForm()`
	`179`	`+ _ = ctx.Req.ParseForm()`
`180`	`180`	`}`
`181`	`181`	`for k, v := range form.Value {`
`182`	`182`	`ctx.Req.Form[k] = append(ctx.Req.Form[k], v...)`
`@@ -284,8 +284,8 @@ func Validate(obj interface{}) macaron.Handler {`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`var (`
`287`		`- AlphaDashPattern = regexp.MustCompile("[^\\d\\w-_]")`
`288`		`- AlphaDashDotPattern = regexp.MustCompile("[^\\d\\w-_\\.]")`
	`287`	+ AlphaDashPattern = regexp.MustCompile(`[^\d\w-_]`)
	`288`	+ AlphaDashDotPattern = regexp.MustCompile(`[^\d\w-_\.]`)
`289`	`289`	EmailPattern = regexp.MustCompile("[\\w!#$%&'+/=?^_`{\|}~-]+(?:\\.[\\w!#$%&'+/=?^_`{\|}~-]+)@(?:[\\w](?:[\\w-][\\w])?\\.)+[a-zA-Z0-9](?:[\\w-]*[\\w])?")
`290`	`290`	`)`
`291`	`291`
`@@ -744,7 +744,7 @@ func ensureNotPointer(obj interface{}) {`
`744`	`744`	`// with errors from deserialization, then maps both the`
`745`	`745`	`// resulting struct and the errors to the context.`
`746`	`746`	`func validateAndMap(obj reflect.Value, ctx *macaron.Context, errors Errors, ifacePtr ...interface{}) {`
`747`		`- ctx.Invoke(Validate(obj.Interface()))`
	`747`	`+ _, _ = ctx.Invoke(Validate(obj.Interface()))`
`748`	`748`	`errors = append(errors, getErrors(ctx)...)`
`749`	`749`	`ctx.Map(errors)`
`750`	`750`	`ctx.Map(obj.Elem().Interface())`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ type (`
`49`	`49`	Coauthor *Person `json:"coauthor"`
`50`	`50`	`HeaderImage *multipart.FileHeader`
`51`	`51`	Pictures []*multipart.FileHeader `form:"picture"`
`52`		- unexported string `form:"unexported"`
	`52`	+ unexported string `form:"unexported"` //nolint
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`EmbedPerson struct {`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ func performErrorTest(t *testing.T, testCase errorTestCase) {`
`149`	`149`
`150`	`150`	`type (`
`151`	`151`	`errorTestCase struct {`
`152`		`- description string`
	`152`	`+ description string //nolint`
`153`	`153`	`errors Errors`
`154`	`154`	`expected errorTestResult`
`155`	`155`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,15 +130,15 @@ func buildRequestWithFile(testCase fileTestCase) *http.Request {`
`130`	`130`	`if err != nil {`
`131`	`131`	`panic("Could not create FormFile (single file): " + err.Error())`
`132`	`132`	`}`
`133`		`- formFileSingle.Write([]byte(testCase.singleFile.data))`
	`133`	`+ _, _ = formFileSingle.Write([]byte(testCase.singleFile.data))`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`for _, file := range testCase.multipleFiles {`
`137`	`137`	`formFileMultiple, err := w.CreateFormFile("picture", file.fileName)`
`138`	`138`	`if err != nil {`
`139`	`139`	`panic("Could not create FormFile (multiple files): " + err.Error())`
`140`	`140`	`}`
`141`		`- formFileMultiple.Write([]byte(file.data))`
	`141`	`+ _, _ = formFileMultiple.Write([]byte(file.data))`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`err := w.Close()`
`@@ -179,7 +179,6 @@ func unpackFileHeaderData(fh *multipart.FileHeader) string {`
`179`	`179`	`type (`
`180`	`180`	`fileTestCase struct {`
`181`	`181`	`description string`
`182`		`- input BlogPost`
`183`	`182`	`singleFile *fileInfo`
`184`	`183`	`multipleFiles []*fileInfo`
`185`	`184`	`}`