Skip to content

Commit 03d9c2b

Browse files
committed
fixup
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
1 parent 98030ff commit 03d9c2b

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/go-test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108
# just on that job rather than each matrix job independently.
109109
needs: [ unit_tests ] # <- requires all unit_tests jobs to be successful.
110110
env:
111-
test_result: '${{ join(needs.unit_tests.outputs.*) }}' # <- this is a comma-separated list of strings
111+
test_result: '${{ join(needs.unit_tests.outputs.*) }}' # <- this is a comma-separated list of quoted strings
112112
runs-on: ubuntu-latest
113113
steps:
114114
- name: Tests complete
@@ -128,10 +128,10 @@ jobs:
128128
name: Some tests have failed
129129
# description: |
130130
# This job is only here to report a summary of failed tests in the github actions UI.
131-
needs: [ unit_tests ] # <- requires all unit_tests jobs to be completed, but not necessarily successfully.
132-
if: ${{ needs.unit_tests.result == 'failure' }}
131+
needs: [ unit_tests ] # <- requires all unit_tests jobs to be completed, but not all where successfull.
132+
if: ${{ failure() }}
133133
env:
134-
test_result: '${{ needs.unit_tests.outputs.test_result }}' # <- this is a JSON map
134+
test_result: '${{ join(needs.unit_tests.outputs.*) }}'
135135
runs-on: ubuntu-latest
136136
steps:
137137
- name: Tests failed

0 commit comments

Comments
 (0)