Skip to content

Commit 2cf5034

Browse files
committed
fix: release monorepo (bash arrays)
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
1 parent 21721a1 commit 2cf5034

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/workflows/bump-release-monorepo.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@ jobs:
279279
NEXT_TAG: ${{ needs.determine-next-tag.outputs.next-tag }}
280280
MESSAGE_TITLE: ${{ inputs.tag-message-title }}
281281
MESSAGE_BODY: ${{ inputs.tag-message-body }}
282+
MODULE_RELATIVE_NAMES: ${{ needs.detect-modules.outputs.bash-relative-names }}
282283
run: |
283284
# Tag all modules similar to hack/tag_modules.sh
284285
# Note: The PR with updated go.mod files has been merged at this point
@@ -302,7 +303,9 @@ jobs:
302303
fi
303304
304305
# Tag all modules
305-
while read -r module_relative_name ; do
306+
declare -a ALL_RELATIVE_MODULES
307+
mapfile -d' ' -t ALL_RELATIVE_MODULES < <(printf "%s" "${MODULE_RELATIVE_NAMES}")
308+
for module_relative_name in "${ALL_RELATIVE_MODULES[@]}"; do
306309
if [[ -z "${module_relative_name}" ]] ; then
307310
module_tag="${NEXT_TAG}" # e.g. "v0.24.0"
308311
else
@@ -317,7 +320,7 @@ jobs:
317320
if [[ -n "${SIGNED}" ]] ; then
318321
git tag -v "${module_tag}"
319322
fi
320-
done < <(echo ${{ needs.detect-modules.outputs.bash-relative-names }})
323+
done
321324
322325
# Save all tags for output
323326
echo "all-tags=${all_tags[@]}" >> "${GITHUB_OUTPUT}"

.github/workflows/prepare-release-monorepo.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130
# Therefore, there is no need to care about the order in which we apply this change.
131131
declare -a ALL_FOLDERS
132132
mapfile -d' ' -t ALL_FOLDERS < <(printf "%s" "${MODULE_PATHS}")
133-
while dir in "${ALL_FOLDERS[@]}"; do
133+
for dir in "${ALL_FOLDERS[@]}"; do
134134
echo "::notice title=processing-module::Processing module in ${dir}"
135135
pushd "${dir}" > /dev/null
136136

0 commit comments

Comments
 (0)