fix: test reports upload should be conditioned by lint (#118)

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

Author: fredbi

.github/workflows/TODO.md

@@ -232,5 +232,5 @@ jobs:
 
   collect-reports:
     needs: [test]
-    if: ${{ !cancelled() }}
+    if: ${{ !cancelled() && needs.test.result != 'skipped' }}
     uses: ./.github/workflows/collect-reports.yml

.github/workflows/go-test-monorepo.yml

@@ -125,5 +125,5 @@ jobs:
 
   collect-reports:
     needs: [test]
-    if: ${{ !cancelled() }}
+    if: ${{ !cancelled() && needs.test.result != 'skipped' }}
     uses: ./.github/workflows/collect-reports.yml

.github/workflows/go-test.yml

@@ -148,6 +148,9 @@ jobs:
             #
             # In some situations, we may have a test dependency of a module on itself and this
             # case must be skipped.
+            #
+            # Caveat: if the module's author forgot to put a proper release (e.g. use pseudo-commit instead of
+            # proper vx.y.z require), this rewrite will be omitted. For now, this edge case is simply ignored.
             current_module=$(go list)
             while read -r module ; do
               echo "::notice title=updating-dependency::Updating ${module} to ${TARGET_TAG}"