fix: address workflow code smell with boolean inputs.

Resolves one github gotcha with boolean input parameters.
Now workflow parameters are enforced to be strings so we don't
have to deal with several ways of evaluating whether something is true
or false.

Chore: enforced consistent formatting standards for github annotations and expressions.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

Author: fredbi

.github/workflows/auto-merge.yml

@@ -7,9 +7,9 @@ on:
         description: |
           Enable automatic approval and merge of PRs initiated by a bot.
 
-        type: boolean
+        type: string
         required: false
-        default: true
+        default: 'true'
       organization-bot:
         description: |
           The bot name for your organization,
@@ -68,7 +68,7 @@ jobs:
       contents: write
       pull-requests: write
     runs-on: ubuntu-latest
-    if: ${{ (inputs.enable-organization-bot == 'true' || inputs.enable-organization-bot == true) && github.event.pull_request.user.login == inputs.organization-bot }}
+    if: ${{ inputs.enable-organization-bot == 'true' && github.event.pull_request.user.login == inputs.organization-bot }}
     env:
       PR_URL: ${{ github.event.pull_request.html_url }}
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/bump-release.yml

@@ -19,19 +19,19 @@ on:
     inputs:
       bump-patch:
         description: Bump a patch version release
-        type: boolean
+        type: string
         required: false
-        default: true
+        default: 'true'
       bump-minor:
         description: Bump a minor version release
-        type: boolean
+        type: string
         required: false
-        default: false
+        default: 'false'
       bump-major:
         description: Bump a major version release
-        type: boolean
+        type: string
         required: false
-        default: false
+        default: 'false'
       tag-message-title:
         description: Tag message title to prepend to the release notes
         required: false
@@ -48,8 +48,8 @@ on:
 
           When enabled, you must pass the GPG secrets to this workflow.
         required: false
-        type: boolean
-        default: true
+        type: string
+        default: 'true'
       cliff-config:
         type: string
         required: false
@@ -125,10 +125,10 @@ jobs:
           fi
 
           echo "next-tag=${NEXT_TAG}" >> "$GITHUB_OUTPUT"
-          echo "::notice title=next-tag:${NEXT_TAG}"
+          echo "::notice title=next-tag::${NEXT_TAG}"
       -
         name: Configure bot credentials
-        if: ${{ inputs.enable-tag-signing == 'true' || inputs.enable-tag-signing == true }}
+        if: ${{ inputs.enable-tag-signing == 'true' }}
         uses: go-openapi/gh-actions/ci-jobs/bot-credentials@6c7952706aa7afa9141262485767d9270ef5b00b # v1.3.0
         # This is using the GPG signature of bot-go-openapi.
         #
@@ -158,7 +158,7 @@ jobs:
             BODY=$(echo "${MESSAGE_BODY}"|tr '|' '\n')
             MESSAGE=$(printf "%s\n%s\n" "${MESSAGE}" "${BODY}")
           fi
-          echo "::notice title=tag-message:${MESSAGE}"
+          echo "::notice title=tag-message::${MESSAGE}"
 
           SIGNED=""
           if [[ '${{ inputs.enable-tag-signing }}' == 'true' ]] ; then

.github/workflows/contributors.yml

@@ -12,8 +12,8 @@ on:
 
           When enabled, commits in the pull request will be signed with the bot's GPG key.
         required: false
-        type: boolean
-        default: true
+        type: string
+        default: 'true'
     secrets:
       github-app-id:
         description: |

.github/workflows/fuzz-test.yml

@@ -45,7 +45,7 @@ jobs:
           echo "matrix<<EOF" >> "${GITHUB_OUTPUT}"
           printenv fuzz_tests >> "${GITHUB_OUTPUT}"
           echo "EOF" >> "${GITHUB_OUTPUT}"
-          echo "::notice title=Fuzz tests found:${fuzz_tests}"
+          echo "::notice title=Fuzz tests found::${fuzz_tests}"
 
   fuzz-test:
     name: fuzz test
@@ -155,4 +155,4 @@ jobs:
         name: Report fuzz corpus cache size
         run: |
           FINAL_SIZE=$(du -m "${CORPUS_DIR}"|cut -f1)
-          echo "::notice title=fuzz corpus size:${FINAL_SIZE}MB"
+          echo "::notice title=fuzz corpus size::${FINAL_SIZE}MB"

.github/workflows/go-test.yml

@@ -99,7 +99,7 @@ jobs:
       -
         name: Tests completed
         run: |
-          echo "::notice title=Success:All tests passed"
+          echo "::notice title=Success::All tests passed"
 
   collect-coverage:
     needs: [test-complete]

.github/workflows/local-bump-release.yml

@@ -15,19 +15,19 @@ on:
     inputs:
       bump-patch:
         description: Bump a patch version release
-        type: boolean
+        type: string
         required: false
-        default: true
+        default: 'true'
       bump-minor:
         description: Bump a minor version release
-        type: boolean
+        type: string
         required: false
-        default: false
+        default: 'false'
       bump-major:
         description: Bump a major version release
-        type: boolean
+        type: string
         required: false
-        default: false
+        default: 'false'
       tag-message-title:
         description: Tag message title to prepend to the release notes
         required: false

experimental/pr-comment.yml

@@ -99,18 +99,18 @@ jobs:
         echo "proceed=true" >> "${GITHUB_OUTPUT}"
 
     - name: Download message artifact
-      if: ${{ steps.check_pr.outputs.proceed == 'true'}} 
+      if: ${{ steps.check_pr.outputs.proceed == 'true' }}
       id: download
       uses: actions/download-artifact@v5
       with:
         run-id: "${{ inputs.run_id }}"
         repository: "${{ env.TARGET }}"
         name: "${{ inputs.artifact_name }}"
         path: artifacts/
-        github-token: ${{secrets.GITHUB_TOKEN}}
+        github-token: ${{ secrets.GITHUB_TOKEN }}
 
     - name: Check message artifact size
-      if: ${{ steps.check_pr.outputs.proceed == 'true'}} 
+      if: ${{ steps.check_pr.outputs.proceed == 'true' }}
       run: |
         MESSAGE_FILE="${{ steps.download.outputs.download-path }}/${{ inputs.artifact_name }}"
         SIZE=$(cat "${MESSAGE_FILE}"|wc -c)
@@ -124,7 +124,7 @@ jobs:
         fi
 
     - name: Find previous PR comment
-      if: ${{ steps.check_pr.outputs.proceed == 'true'}} 
+      if: ${{ steps.check_pr.outputs.proceed == 'true' }}
       uses: peter-evans/find-comment@v3
       id: find_comment
       with:
@@ -135,7 +135,7 @@ jobs:
         token: ${{ secrets.GITHUB_TOKEN }}
 
     - name: Create or update PR comment
-      if: ${{ steps.check_pr.outputs.proceed == 'true'}} 
+      if: ${{ steps.check_pr.outputs.proceed == 'true' }}
       uses: peter-evans/create-or-update-comment@v4
       with:
         issue-number: ${{ inputs.pr_number }}