Commit 2e04a26
committed
fix: handle swagger:type array by falling through to underlying type resolution
When swagger:type is set to a value not handled by swaggerSchemaForType
(e.g., "array"), the function returns an error. Previously this error was
silently ignored and the function returned nil, losing all type info.
Now, when swaggerSchemaForType returns an error, the code falls through
to buildFromType with the underlying type, producing the correct schema.
For example, swagger:type array on type StringSlice []string now produces
{type: "array", items: {type: "string"}} with the field's description
preserved, instead of a $ref that drops the description.
* fixes #10
Signed-off-by: Kevin Doan <kevin.doan@ory.sh>
Signed-off-by: KT-Doan <kevin.doan@ory.sh>1 parent 4b94238 commit 2e04a26
4 files changed
Lines changed: 47 additions & 5 deletions
File tree
- fixtures/goparsing/classification/models
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
799 | 799 | | |
800 | 800 | | |
801 | 801 | | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
429 | 429 | | |
430 | 430 | | |
431 | 431 | | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
436 | 441 | | |
437 | 442 | | |
438 | 443 | | |
| |||
600 | 605 | | |
601 | 606 | | |
602 | 607 | | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
603 | 618 | | |
604 | 619 | | |
605 | 620 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2582 | 2582 | | |
2583 | 2583 | | |
2584 | 2584 | | |
| 2585 | + | |
| 2586 | + | |
| 2587 | + | |
| 2588 | + | |
| 2589 | + | |
| 2590 | + | |
| 2591 | + | |
| 2592 | + | |
| 2593 | + | |
| 2594 | + | |
| 2595 | + | |
| 2596 | + | |
| 2597 | + | |
| 2598 | + | |
| 2599 | + | |
| 2600 | + | |
| 2601 | + | |
0 commit comments