fix(condition): in async testing, allow condition goroutine to exit

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

Author: fredbi

internal/assertions/condition.go

@@ -558,9 +558,21 @@ func (p *conditionPoller) executeCondition(parentCtx, ctx context.Context, failF
 				case <-ctx.Done():
 					return // timeout = success
 				case fn := <-p.conditionChan:
-					if err := fn(ctx); err != nil {
-						close(p.doneChan) // (condition true <=> returns error) = failure for Never and Consistently
+					var conditionWg sync.WaitGroup
+					conditionWg.Add(1)
+					go func() { // guards against the condition issue an early GoExit
+						defer conditionWg.Done()
+
+						if err := fn(ctx); err != nil {
+							close(p.doneChan) // (condition true <=> returns error) = failure for Never and Consistently
+						}
+					}()
+					conditionWg.Wait()
+
+					select {
+					case <-p.doneChan: // done: early exit
 						return
+					default:
 					}
 				}
 			}
@@ -577,9 +589,21 @@ func (p *conditionPoller) executeCondition(parentCtx, ctx context.Context, failF
 				failFunc(ctx.Err().Error())
 				return
 			case fn := <-p.conditionChan:
-				if err := fn(ctx); err == nil {
-					close(p.doneChan) // (condition true <=> err == nil) = success for Eventually
+				var conditionWg sync.WaitGroup
+				conditionWg.Add(1)
+				go func() { // guards against the condition issue an early GoExit
+					defer conditionWg.Done()
+
+					if err := fn(ctx); err == nil {
+						close(p.doneChan) // (condition true <=> err == nil) = success for Eventually
+					}
+				}()
+				conditionWg.Wait()
+
+				select {
+				case <-p.doneChan: // done: early exit
 					return
+				default:
 				}
 			}
 		}