feat: Add ISIN validator#1570
Open
walle250ai wants to merge 1 commit into
Open
Conversation
Adds an `isin` struct tag validator for International Securities Identification Numbers (ISO 6166). Validation checks: 1. Format: 2-letter country code + 9 alphanumeric chars + 1 check digit 2. Luhn checksum: letters are expanded to their two-digit values (A=10 … Z=35) before applying the standard Luhn algorithm. - regexes.go: add isinRegexString and isinRegex - baked_in.go: register "isin" tag and implement isISIN() - validator_test.go: add TestISINStringValidation with valid ISINs (Apple, BP, BASF) and invalid cases (length, format, checksum, lowercase)
zemzale
requested changes
Apr 29, 2026
Member
zemzale
left a comment
zemzale
left a comment
There was a problem hiding this comment.
Thanks for the PR.
The code looks good, but I would ask you to also update the docs before we can merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
isinstruct tag validator for International Securities Identification Numbers (ISO 6166). Validation checks:Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers