fix(iso4217): remove BGN as Bulgaria adopted EUR on 2026-01-01#1584
Open
64johnlee wants to merge 1 commit into
Open
fix(iso4217): remove BGN as Bulgaria adopted EUR on 2026-01-01#158464johnlee wants to merge 1 commit into
64johnlee wants to merge 1 commit into
Conversation
Bulgaria replaced the Bulgarian lev (BGN, numeric 975) with the Euro on January 1, 2026. Remove BGN from the iso4217 alpha map and 975 from the iso4217 numeric map so the validator reflects the current standard. Add negative test cases to confirm BGN/975 are no longer accepted. Closes go-playground#1517 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Just a gentle ping — this PR has an approval from @nodivbyzero and all CI checks are green across Go 1.25/1.26 on Ubuntu, macOS, and Windows. Happy to rebase if needed, but it looks ready to merge whenever you get a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bulgaria replaced the Bulgarian lev (BGN, ISO 4217 numeric 975) with the Euro on January 1, 2026. This PR removes
BGNfrom theiso4217alpha map and975from theiso4217_numericmap so the validator reflects the current ISO 4217 standard.Closes #1517
Changes
currency_codes.go— removed"BGN": {}fromiso4217alpha map and975: {}fromiso4217_numericmapvalidator_test.go— added{"BGN", false}toTestIsIso4217Validationand{975, false}toTestIsIso4217NumericValidationto assert BGN/975 are no longer acceptedTest plan
go build ./...passesgo test ./...passes (all packages)