add ExpectDo methods#26
Open
ideasculptor wants to merge 4 commits into
Open
Conversation
|
Any progress on That?? @ideasculptor @ryantate13 |
Author
|
I'll update the PR so that it is up to date with go-redis:master but I doubt either of us is going to find ourselves with the time to do the full implementation that would be required to get someone to merge this any time soon. This fork serves our needs sufficiently as it is. Check back in a few hours and I should have the PR updated. |
5aebb94 to
358245b
Compare
Author
done |
Member
|
// or []interface{}{int64(100), int64(200)}
mock.ExpectDo("hkeys", "hkey").SetVal([]interface{}{"100", "200"})
v, err := client.Do(ctx, "hkeys", "hkey").Int64Slice()
t.Log(v, err) |
|
This looks like what we are missing... Any progress on this ? @monkey92t @ideasculptor |
Author
|
Neither @ryantate13 nor I works at the company where we did that work any longer, so
whatever progress we made is no longer accessible to us -
unless Ryan has a copy of source code. I don't. But i know we had
something working in the code, so I suspect I got something to work in a
manner that made sense. But I have no recollection of what it was, sorry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added example implementations for handling Do() with various return types. Needs to be fleshed out with all of the various potential return types and tests, but demonstrates the concept. I may eventually get around to implementing the feature in its entirety, but probably not anytime soon, unfortunately, so this PR exists largely for documentary purposes in the associated issue: #25