Update mock.go to call hooks that are added to mock client#74
Open
cjweber wants to merge 2 commits into
Open
Conversation
Author
|
@monkey92t is there any chance my PR could be reviewed? I would love to use v9 mock for my telemetry hook tests using go-redis v9. |
|
Is this project abandoned? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating to go-redis-v9, I found that the hooks were not getting executed in tests. This change makes it so hooks that are added to the mock client are executed as expected, per https://uptrace.dev/blog/go-redis-v9.html#improved-hooks.