Brace expansion broken in v3.44.1 due to over-escaping of curly braces

[junhaoliao]

Description

In version 3.44.1, commit d2bd834 introduced an escape function that incorrectly escapes curly braces { and } in shell commands. This breaks brace expansion functionality, causing commands like ls file.{txt,md} to fail because the braces are escaped to \{ and \}, preventing shell expansion.

Steps to Reproduce

1. Create a Taskfile.yaml with brace expansion as shown in the "Example Taskfile"
2. Run the task: task

Expected behavior

The first command should create file.txt and file.md, and the second command should find and list these files.

Actual Behavior

The brace expansion is broken due to escaping, so the commands fail to work as intended. The ls command looks for a literal file named file.{txt,md} instead of expanding to file.txt and file.md.

Version

3.44.1

Operating system

Ubuntu 22.04.5 LTS (Jammy Jellyfish) # $ bash --version GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)

Experiments Enabled

No response

Example Taskfile

version: "3"

tasks:
  default:
    cmds:
      - "touch file.{txt,md}"
      - >-
        ls "file."{txt,md} || echo 'Files not found'

[pd93]

This seems to be an ongoing saga. We need to create some tests to stop these regressions.

Related:

• Having & in Directory name causing problems. #1551
• ( is not a valid word #1590
• Using glob curly braces expansion in sources prevents change detection for some files #2073
• fix: sources brace expansion #2075
• Task creates spurious brand new directories on disk with backslashes preceding every space #2208
• fix: double escaped paths #2216
• fix: spaces in path #2322 (breaking PR)

[Bill-hbrhbr]

@junhaoliao Tested with go-task v3.48. Your example taskfile no longer creates the bug seen in v3.44.1
@pd93 Thank you for patching this bug. I think it's safe to close this issue now.

[junhaoliao]

thanks @pd93 for fixing the issue, and @Bill-hbrhbr for confirming the latest version of go-task works with @y-scope projects!