fix: report cancellation reason when parallel tasks fail in failfast mode#2870
Closed
toller892 wants to merge 1 commit into
Closed
fix: report cancellation reason when parallel tasks fail in failfast mode#2870toller892 wants to merge 1 commit into
toller892 wants to merge 1 commit into
Conversation
…mode When failfast is enabled and a parallel task fails, other running tasks are cancelled via context but the error message only shows 'context cancelled' without explaining why. Use context.Cause() to extract the original error and include it in the cancellation message. Fixes go-task#1226
Contributor
|
AI Bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When failfast is enabled and multiple tasks run in parallel, if one task fails, the other running tasks are cancelled via context. However, the error message only shows
context cancelledwithout explaining why the task was cancelled. This makes it hard for users to understand what happened.Current behavior:
The user sees
context canceledforCI:testbut has no idea it was cancelled becauseCI:lintfailed.Solution
Use
context.Cause()to extract the original error that triggered the cancellation and include it in the error message. Theerrgroup.WithContextfunction (used when failfast is enabled) stores the first error as the context cause viacontext.WithCancelCause.New behavior:
Changes
task.go: AddedenrichCancellationErrorhelper that checks forcontext.Cancelederrors and enriches them with the cause fromcontext.Cause(ctx)Run()(top-level parallel tasks) andrunDeps()(dependency tasks)Testing
TestFailfastFixes #1226