decode: skip mapstructure:"-" fields so ErrorUnset doesn't flag them#191
Open
c-tonneslan wants to merge 1 commit into
Open
decode: skip mapstructure:"-" fields so ErrorUnset doesn't flag them#191c-tonneslan wants to merge 1 commit into
mapstructure:"-" fields so ErrorUnset doesn't flag them#191c-tonneslan wants to merge 1 commit into
Conversation
Closes mitchellh#89. mapstructure:"-" means a field is opted out of decoding, but the decoder still walked it during struct iteration and added the literal "-" key to Metadata.Unset, which made ErrorUnset trip on it. Honour the tag by continuing past the field, matching how the encoder already handles it. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89.
mapstructure:"-"means a field is opted out of decoding, but the decoder still walked it during struct iteration and added the literal"-"key toMetadata.Unset, which madeErrorUnsettrip on it. Honour the tag by continuing past the field, matching how the encoder already handles it.