Skip to content

Commit 68c77a7

Browse files
authored
Prefix interceptor var with service to avoid collision (#3905)
1 parent 662e850 commit 68c77a7

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

codegen/cli/cli.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ func BuildCommandData(data *service.Data) *CommandData {
167167
var interceptors *InterceptorData
168168
if len(data.ClientInterceptors) > 0 {
169169
interceptors = &InterceptorData{
170-
VarName: "inter",
170+
VarName: codegen.Goify(data.Name, false) + "Inter",
171171
PkgName: data.PkgName,
172172
}
173173
}
@@ -226,7 +226,7 @@ func BuildSubcommandData(data *service.Data, m *service.MethodData, buildFunctio
226226
var interceptors *InterceptorData
227227
if len(m.ClientInterceptors) > 0 {
228228
interceptors = &InterceptorData{
229-
VarName: "inter",
229+
VarName: codegen.Goify(data.Name, false) + "Inter",
230230
PkgName: data.PkgName,
231231
}
232232
}

grpc/codegen/testdata/endpoint-endpoint-with-interceptors.golden

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func UsageExamples() string {
3535
// line.
3636
func ParseEndpoint(
3737
cc *grpc.ClientConn,
38-
inter servicewithinterceptors.ClientInterceptors,
38+
serviceWithInterceptorsInter servicewithinterceptors.ClientInterceptors,
3939
opts ...grpc.CallOption,
4040
) (goa.Endpoint, any, error) {
4141
var (
@@ -118,11 +118,11 @@ func ParseEndpoint(
118118
switch epn {
119119
case "method-a":
120120
endpoint = c.MethodA()
121-
endpoint = servicewithinterceptors.WrapMethodAClientEndpoint(endpoint, inter)
121+
endpoint = servicewithinterceptors.WrapMethodAClientEndpoint(endpoint, serviceWithInterceptorsInter)
122122
data, err = servicewithinterceptorsc.BuildMethodAPayload(*serviceWithInterceptorsMethodAMessageFlag)
123123
case "method-b":
124124
endpoint = c.MethodB()
125-
endpoint = servicewithinterceptors.WrapMethodBClientEndpoint(endpoint, inter)
125+
endpoint = servicewithinterceptors.WrapMethodBClientEndpoint(endpoint, serviceWithInterceptorsInter)
126126
data, err = servicewithinterceptorsc.BuildMethodBPayload(*serviceWithInterceptorsMethodBMessageFlag)
127127
}
128128
}

0 commit comments

Comments
 (0)