Always end template files in a newline#3687
Merged
Merged
Conversation
- Remove spurious newline in parse_endpoint - Update test (leave trailing whitespace alone)
- request_init.go.tpl needs to strip it - Most partials need to strip, but handle once inside templates.go
- codegen/service/templates/return_type_init.go.tpl removes this with a
trailing dash, as the say it's consumed through validations is hard to
follow and fix
- example now spaces out before var(){} blocks including after flag.Parse()
Member
|
This is something that had been in the back of my mind for a long time now - really appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most templates this works fine. For a few templates, this throws off whitespace.
fixes #3681