eval: report validation error locations#3895
Merged
Merged
Conversation
Add file:line prefixes to validation errors when the failing expression has a DSL function pointer. Refactor DSL error location resolution to skip internal Goa frames reliably and add tests that assert locations for both DSL and validation errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file:lineprefixes to validation errors when the failing expression has a DSL function pointer, making it straightforward to locate the offending design declaration.computeErrorLocationto useruntime.CallersFramesinstead of repeatedruntime.Callercalls, which is robust to inlining and avoids hardcoding call-depth assumptions.isGoaSourceFileto reliably skip internal Goa frames even when inlining collapses the stack.validationErrorLocation/dslFuncLocationto derive locations from the expression's DSL function pointer forValidate()-phase errors.RunDSLerror propagation.Test plan
make test— all passingmake lint— 0 issueseval/error_location_test.goandeval/run_dsl_error_location_test.goexpr/validation tests updated for new location prefixes