Support cookie-backed API key security inference#3910
Merged
Conversation
raphael
reviewed
Mar 13, 2026
raphael
left a comment
raphael
left a comment
Member
There was a problem hiding this comment.
Look great! thank you for the PR. I left a couple of minor comments that would be good to address before we can merge this in.
| // IsSecurityParameter returns true if the given HTTP transport element is used | ||
| // by one of the endpoint security schemes and should therefore not be emitted | ||
| // again as a regular OpenAPI parameter. | ||
| func IsSecurityParameter(endpoint *expr.HTTPEndpointExpr, in, name string) bool { |
Member
There was a problem hiding this comment.
Might be better to keep this private, this is probably not something that the openapi package should expose.
| } | ||
|
|
||
| func paramsFromExpr(params *expr.MappedAttributeExpr, path string) []*Parameter { | ||
| return paramsFromExprForEndpoint(nil, params, path) |
Member
There was a problem hiding this comment.
Can we avoid this wrapping? I don't know why LLMs insist in making these :)
Contributor
Author
There was a problem hiding this comment.
they have their quirks! I also made a small amendment to AGENTS.md in the same commit to attempt avoiding the same type of behavior in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #3909