ci: drop Go 1.24 from matrix (go.mod requires Go 1.25)#3931
Merged
Conversation
Member
|
Good catch, thank you. I've updated the branch protection required checks as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'1.24'from thecijob's Go version matrix in.github/workflows/test.ymlAGENTS.mdGo style guideline fromGo 1.24+toGo 1.25+to matchPrepare v3.27.0 (420dd780) bumped
go.modfromgo 1.24.0togo 1.25.0and removed thetoolchaindirective, making Go 1.25 the new minimum. The CI matrix intest.ymland theGo Code Styleline inAGENTS.mdwere not updated in the same change, so every PR opened againstv3since then has been failing onci (1.24, ubuntu-latest)with:Go 1.24's toolchain cannot build a module that declares
go 1.25, so thego test ./... --coverprofile=cover.outstep fails for packages that contain no test files (where the build falls back to the coverage-instrumentation path that needs thecovdatatool).Examples: #3929, #3930 — both fail on 1.24 and pass on 1.25 despite having no coverage-related changes, confirming the failure is toolchain-gated rather than test-logic-specific.
The
Upload test coverage for deep sourcestep already gates onmatrix.go == '1.25', so dropping 1.24 has no side effect there.Test plan
go.moddeclaresgo 1.25.0