Skip to content

ci: add dependency-review workflow#22464

Open
GirlBossRush wants to merge 1 commit into
mainfrom
ci/dependency-review
Open

ci: add dependency-review workflow#22464
GirlBossRush wants to merge 1 commit into
mainfrom
ci/dependency-review

Conversation

@GirlBossRush
Copy link
Copy Markdown
Contributor

Summary

Adds .github/workflows/qa-dependency-review.yml, which runs actions/dependency-review-action@v5.0.0 on every PR targeting main.

Blocks PRs that introduce a new dependency (direct or transitive, any ecosystem GitHub supports — npm, Go modules, Python, GitHub Actions) with a known high or critical vulnerability.

How this fits the rest of the supply-chain hardening

  • Dependabot surfaces vulns in already-merged deps (the existing flow).
  • dependency-review catches them at the moment they would be introduced, before merge — Dependabot only sees the world after merge.
  • It does not catch the maintainer-account-hijack-to-malicious-version case directly (no advisory exists yet for those). The defense for that is the existing .npmrc:1 ignore-scripts=true + Dependabot npm cooldown.

This action does not need access to the dependency graph beyond what the PR diff exposes, so the only permission it needs is pull-requests: write (to leave the summary comment on failure) plus contents: read.

Config

  • fail-on-severity: high — block on high/critical only; lower-severity introductions surface in the check summary but don't gate merge
  • comment-summary-in-pr: on-failure — when the action blocks a PR, post a diff-style summary as a comment so the reviewer sees context, not just a red check

Test plan

  • Workflow appears on this PR's checks list as QA - Dependency review / dependency-review.
  • Passes for this PR (no dependency changes in this diff).
  • On a follow-up PR that bumps a vulnerable package version, the check fails and posts a summary comment.

@GirlBossRush GirlBossRush requested a review from a team as a code owner May 19, 2026 11:36
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.29%. Comparing base (f992754) to head (056b5cc).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22464   +/-   ##
=======================================
  Coverage   93.28%   93.29%           
=======================================
  Files        1032     1032           
  Lines       60059    60059           
  Branches      400      400           
=======================================
+ Hits        56029    56031    +2     
+ Misses       4030     4028    -2     
Flag Coverage Δ
conformance 36.61% <ø> (+<0.01%) ⬆️
e2e 41.86% <ø> (-0.02%) ⬇️
integration 33.05% <ø> (+<0.01%) ⬆️
rust 0.00% <ø> (ø)
unit 88.04% <ø> (-4.17%) ⬇️
unit-migrate 92.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 275f0e3
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6a0c4b3ca6199600083695cb
😎 Deploy Preview https://deploy-preview-22464--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Adds a `QA - Dependency review` workflow that runs
`actions/dependency-review-action` on every PR targeting `main`.

This blocks PRs that introduce a *new* dependency (direct or transitive)
with a known high or critical vulnerability in GitHub's Advisory
Database. It complements rather than duplicates Dependabot: Dependabot
surfaces vulns in already-merged dependencies; dependency-review catches
them at the moment they would be introduced.

It also catches the much narrower case that motivated this PR — a
maintainer-account-hijack publishing a malicious version to npm — only
indirectly: GitHub will not have an advisory entry until the package
has been flagged. The real value here is keeping the much larger class
of "newly introduced dep happens to carry a known CVE" out of the tree.

Configured with:

  - fail-on-severity: high  (block on high/critical only)
  - comment-summary-in-pr: on-failure  (surface diff context to
                                        reviewers when a block fires)

Pinned to v5.0.0 (a1d282b36b6f3519aa1f3fc636f609c47dddb294).

Co-authored-by: Agent <279763771+playpen-agent@users.noreply.github.com>
@GirlBossRush GirlBossRush force-pushed the ci/dependency-review branch from 275f0e3 to 056b5cc Compare May 20, 2026 02:09
Comment on lines +6 to +7
# Advisory Database supports — for this repo that's npm, Go modules,
# Python (pip/uv), and GitHub Actions.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that also include rust dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants