Skip to content

There are cases where you want the delimiter to be a space#31

Closed
arran4 wants to merge 1 commit into
gobeam:masterfrom
arran4:patch-1
Closed

There are cases where you want the delimiter to be a space#31
arran4 wants to merge 1 commit into
gobeam:masterfrom
arran4:patch-1

Conversation

@arran4

@arran4 arran4 commented Dec 11, 2024

Copy link
Copy Markdown

I figure that if the user is just passing in a single " " then that would match that case. However it don't handle the case of multiple " " being intentional -- I'm not sure how you would want to handle this.

Perhaps, if the change should be on 173?

Description

When using this I found a case where I wanted a ' ' delimiter.

Fixes n/a

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This has not been testing being trivial and expecting push back.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

I figure that if the user is just passing in a single " " then that would match that case. However it don't handle the case of multiple `"  "` being intentional -- I'm not sure how you would want to handle this.

Perhaps, if the change should be on 173?
@arran4

arran4 commented Jun 19, 2026

Copy link
Copy Markdown
Author

Closing because I presume it's fully encorporated into #33

@arran4 arran4 closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant