(BEDS-1462) maxEB Banner for GuestDB#1513
Merged
Merged
Conversation
Deploying beaconchain with
|
| Latest commit: |
4605536
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5a6e6c97.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-1462-premium-warning-gu.beaconchain.pages.dev |
remoterami
force-pushed
the
BEDS-1462/premium-warning-guests
branch
from
404acf8 to
47607a8
Compare
| apr: PeriodicValues<ClElValue<number /* float64 */>>; | ||
| chart_history_seconds: ChartHistorySeconds; | ||
| balances: ValidatorBalances; | ||
| is_above_eb_limit: boolean; // refers to owner; relevant for shared dashboards |
Contributor
There was a problem hiding this comment.
suggestion (if-minor): without context it is really hard to guess what eb stands for
Suggested change
| is_above_eb_limit: boolean; // refers to owner; relevant for shared dashboards | |
| hasExceededEffectiveBalance: boolean; |
Contributor
There was a problem hiding this comment.
nitpick: imo the context why this change is necessary should be explained in the body of your commit msg
remoterami
force-pushed
the
BEDS-1462/premium-warning-guests
branch
from
47607a8 to
7118d57
Compare
marcel-bitfly
force-pushed
the
BEDS-1462/premium-warning-guests
branch
2 times, most recently
from
77cbdff to
1e80249
Compare
enzo-bitfly
reviewed
Apr 17, 2025
marcel-bitfly
force-pushed
the
BEDS-1462/premium-warning-guests
branch
from
2a1863d to
41aad2f
Compare
needed because external dashboard viewers can't query the owners premium limits
…ashboard` is reached See: BEDS-1462
Using `!important` broke other `BcNotificationBanner` link color. See: f8d6e49
Changed the file name as `encryption` and `encoding` are two different things.
…lidators` that would exceed `maximum effective balance`
marcel-bitfly
force-pushed
the
BEDS-1462/premium-warning-guests
branch
from
98a5d89 to
4605536
Compare
enzo-bitfly
approved these changes
Apr 29, 2025
Contributor
enzo-bitfly
left a comment
enzo-bitfly
left a comment
There was a problem hiding this comment.
It is cleaner than before though 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.