fix(client): add Content-Length: 0 for bodyless POST/PUT/PATCH requests#52
Open
Swaagie wants to merge 1 commit into
Open
fix(client): add Content-Length: 0 for bodyless POST/PUT/PATCH requests#52Swaagie wants to merge 1 commit into
Swaagie wants to merge 1 commit into
Conversation
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Akamai (and other CDN/edge layers in front of the GoDaddy API) require a
Content-Length: 0header on POST, PUT, and PATCH requests that carry no body. Without it, calls toverify-acmeandverify-dnsreturn HTTP 411 Bad Request with an HTML error page from the edge layer — not a meaningful API error.The
requestmethod now setsContent-Length: 0automatically whenbodyisNonefor mutating HTTP methods.Test plan
verify-acmeno longer returns HTTP 411 behind Akamai edgeverify-dnsno longer returns HTTP 411 behind Akamai edge