fix(deps): upgrade hickory-resolver 0.25 → 0.26 to fix RUSTSEC-2026-0118/0119#53
Open
Swaagie wants to merge 2 commits into
Open
fix(deps): upgrade hickory-resolver 0.25 → 0.26 to fix RUSTSEC-2026-0118/0119#53Swaagie wants to merge 2 commits into
Swaagie wants to merge 2 commits into
Conversation
…118/0119 Upgrades hickory-resolver and hickory-proto from 0.25 to 0.26.1, which resolves both CVEs affecting hickory-proto 0.25.2: - RUSTSEC-2026-0119: CPU exhaustion via crafted DNS response (fixed >=0.26.1) - RUSTSEC-2026-0118: NSEC3 unbounded hash iteration (fixed in 0.26) Migrates crates/ans-verify/src/dns.rs to the 0.26 API: - TokioConnectionProvider -> hickory_resolver::net::runtime::TokioRuntimeProvider - ResolverConfig presets (cloudflare/google/quad9) -> ResolverConfig::udp_and_tcp/tls(&CLOUDFLARE/GOOGLE/QUAD9) - NameServerConfigGroup::from_ips_clear -> Vec<NameServerConfig::udp_and_tcp> - builder.build() now returns Result, propagate with map_err - Error matching: ResolveErrorKind/ProtoErrorKind -> NetError/HickoryDnsError directly - response.iter() -> response.answers() with RData::TXT/TLSA pattern matching - TLSA fields now pub, use u8::from(field) instead of method calls
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hickory-resolver/hickory-protofrom0.25to0.26.1, resolving both security advisories affectinghickory-proto 0.25.2:crates/ans-verify/src/dns.rsto the 0.26 API — the only crate that directly depends on hickory internals.API changes in hickory 0.26
TokioConnectionProviderhickory_resolver::net::runtime::TokioRuntimeProviderResolverConfig::cloudflare()ResolverConfig::udp_and_tcp(&CLOUDFLARE)ResolverConfig::cloudflare_tls()ResolverConfig::tls(&CLOUDFLARE)ResolverConfig::google/quad9variants&GOOGLE/&QUAD9NameServerConfigGroup::from_ips_clearVec<NameServerConfig::udp_and_tcp(ip)>builder.build()→Resolverbuilder.build()→Result<Resolver, NetError>e.kind()→ResolveErrorKind::Proto(p)thenp.kind()→ProtoErrorKind::*eisNetErrordirectly — match onNetError::Dns(HickoryDnsError::*)/NetError::Timeoutresponse.iter()onTxtLookup/TlsaLookupresponse.answers()→&[Record], pattern-matchRData::TXT/TLSAtlsa.cert_usage()(method)tlsa.cert_usage(pub field),u8::from(tlsa.cert_usage)Test plan
cargo build— clean build across full workspacecargo test -p ans-verify— 160 passed, 0 failed, 1 ignoredcargo deny check advisories— should report no vulnerabilities forhickory-proto